Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359935

Summary:	Links generated by search are broken
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	libingw, simon_kaegi
Version:	0.3
Target Milestone:	0.3 RC1
Hardware:	All
OS:	All
Whiteboard:

Description Mark Macdonald

2011-10-04 20:43:22 EDT

Orion 0.3 10/04

1. Log in to Orion
2. Press the 't' key to open the "Find File Named" dialog
3. Type in a query that returns some results
4. Try to open one of the results. The URL is invalid and doesn't load.

The URL looks like:
http://localhost:8080../edit/edit.html#/file/a/bundles/org.eclipse.orion.client.core/web/orion/searchClient.js

Same problem applies to the results returned by a global search from the Orion toolbar.

Comment 1 libing wang

2011-10-04 21:41:04 EDT

(In reply to comment #0)

> The URL looks like:
> http://localhost:8080../edit/edit.html#/file/a/bundles/org.eclipse.orion.client.core/web/orion/searchClient.js

searchClient.js used  [hostname + "edit/edit.html"] before(line 169, 228), after changing it to  hostname + require.toUrl("edit/edit.html") , it no longer works.
I removed hostname part , seems working now.

Comment 2 libing wang

2011-10-04 21:46:13 EDT

fixed wit h69b421e352c65acf82659c9757f9c61a26151651

Comment 3 Simon Kaegi

2011-10-04 23:21:51 EDT

Good Catch. I've updated many urls over the last couple of days and fully missed the hostname on this one. Thanks Libing.