Bugzilla – Full Text Bug Listing
| Summary: | [commands] are the various rendering css classes necessary? | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Susan McCourt <susan> |
| Component: | Client | Assignee: | Susan McCourt <susan> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | unspecified | ||
| Target Milestone: | 0.4 M1 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
There were no more uses of cssClass in any calls to renderCommands. The new parameters (cssCmdLink, cssCmdLinkOver) were related to the searchXXXX specific command styles mentioned above. This appeared to be an attempt reduce the spacing between commands. I fixed this in command layer and got rid of all extra styling parameters. Fixed in cb366116c0e82621772e1e018cbfff1c1fb7f981 |
we have slowly added a bunch of custom css classes that can be added when rendering commands. So we have stuff like if (cssClass) { dojo.addClass(img, cssClass) } else { dojo.addClass(img, "commandImage") } We have added them for regular rendering, hover, etc. It's getting very hard to follow. Need to look at the client uses and figure out if there's a better way (such as supplying the command framework with the various classes used on a page). Possibly related, there are a bunch of custom "searchXxx" copies of most of the command classes in commands.css. Need to figure out why they are, ideally the standard classes should be usable in all orion pages and if they are not, figure out why they need to be different. Once done, if we still need these custom classes we should document their expected usage.