Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359876

Summary:	Debug icon only appears in first VE preview tab
Product:	z_Archived	Reporter:	Justin Spadea <jspadea>
Component:	EDT	Assignee:	Justin Spadea <jspadea>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description Justin Spadea

2011-10-04 12:57:38 EDT

The contributions for the preview's toolbar incorrectly implemented. It turns out that there is only one instance of the action contribution, so when telling it to fill into the preview's toolbar it only does so if it's not already in a toolbar.

Ideally all the buttons in the preview and design toolbars would be singleton (for the hard-coded buttons each editor currently creates a new instance). We will make that a separate work item for 1.0. For 0.7.0 we should have a singleton "contribution toolbar" that gets inserted next to the hard-coded preview toolbar items. This way contributed actions will show up for every editor.

Comment 1 Justin Spadea

2011-10-05 14:12:23 EDT

After discussing this a bit, we decided to remove the icon from the toolbar. It's redundant, the common debug icon in the main workbench toolbar does exactly the same thing.

Since the contribution code only works for the first open editor, it has been removed from EvPreviewToolbar.java. We can make it extensible in a future release.

Comment 2 Justin Spadea

2011-10-31 15:48:16 EDT

Verified