Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359870

Summary: Provide generators the ability to write to the Generate Result dialog box
Product: [Technology] Tigerstripe Reporter: Navid Mehregani <nmehrega>
Component: PluginAssignee: Project Inbox <tigerstripe.plugin-inbox>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: skanton
Version: unspecified   
Target Milestone: 0.5M0   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
Generate Result Dialog
none
Generation Result Dialog patch none

Description Navid Mehregani CLA 2011-10-04 12:32:17 EDT 
Build Identifier: 

At the moment, generators do not have the ability to write to the Generate Result dialog box (as attached).  This enhancement is a request to provide generators the ability to write to this dialog.  Three types of messages can be written:

ERROR: Displayed in red
WARNING: Displayed in orange
INFO: Displayed in black 

If there are different message types used, everything should be displayed in red if it contains errors or in orange if it contains warnings. 

Reproducible: Always
Comment 1 Navid Mehregani CLA 2011-10-04 12:33:31 EDT 
Created attachment 204524 [details]
Generate Result Dialog
Comment 2 Anton Salnik CLA 2011-10-13 08:46:17 EDT 
It's not fully clear how to display the log messages. Do you want to combine the messages with current or use a separete area for them? Current logging implementation is based on IStatus objects and the objects are converted to string at generation end. What do you think if we reuse logic from Error log view and display the messages in tabular way?
Comment 3 Navid Mehregani CLA 2011-10-13 13:27:47 EDT 
(In reply to comment #2)
> It's not fully clear how to display the log messages. Do you want to combine
> the messages with current or use a separete area for them? Current logging
> implementation is based on IStatus objects and the objects are converted to
> string at generation end. What do you think if we reuse logic from Error log
> view and display the messages in tabular way?

I was thinking of displaying them as string in the existing textbox.  It'll be more work if we want to display it in tabular format.  Let's further discuss this in our status call.
Comment 4 Navid Mehregani CLA 2011-10-17 10:13:31 EDT 
Code review will be required for this enhancement.
Comment 5 Navid Mehregani CLA 2011-10-17 10:40:12 EDT 
In the status call it was decided to display this information in tabular format similar to Error Log view.
Comment 6 Anton Salnik CLA 2011-10-31 00:02:27 EDT 
Created attachment 206187 [details]
Generation Result Dialog patch

Generators log is diaplayed in tabular form. To see a log entry details double click on it. Generators are able to add log entries with using PluginLog.reportStatus(IStatus).
Comment 7 Navid Mehregani CLA 2011-11-07 10:58:35 EST 
Anton, can you please add a quick wiki page with a simple example of how generators can leverage this feature? Thanks!
Comment 9 Navid Mehregani CLA 2011-11-10 10:34:24 EST 
Code review was completed on Nov 10 2011.
Comment 10 Anton Salnik CLA 2011-11-13 23:07:31 EST 
Patch applied.
Comment 11 Navid Mehregani CLA 2011-12-01 15:45:04 EST 
Looks great, thank you!