Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359838

Summary:

[workspace selection] The "Workspace Unavailable" error message does not list the workspace location

Product:

[Eclipse Project] Platform

Reporter:

Helmut J. Haigermoser <helmut.haigermoser>

Component:

Assignee:

Oleg Besedin <ob1.eclipse>

Status:

RESOLVED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

pwebster, remy.suen

Version:

3.7

Target Milestone:

3.8 M4

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Error dialog describing the problem: WS is in use.	none
proposed patch to address this issue	ob1.eclipse: iplog+

Description Helmut J. Haigermoser

2011-10-04 09:59:00 EDT

Build Identifier: 

If the chosen workspace is locked Eclipse will not be able to use it and show an error dialog (see attachment). This dialog does report the workspace to be in use, but it does not list the workspace location.

Some users start their Eclipse with preconfigured workspaces, these users in particular would benefit from this dialog stating the workspace location again, which seems like a small and risk-free change with some value to it !:)

Let me know what you think

Reproducible: Always

Steps to Reproduce:
1. Start Eclipse with Workspace "C:\data"
2. Start another Eclipse with the same Workspace
3. see error for the second Eclipse instance does not contain the ws location

Comment 1 Helmut J. Haigermoser

2011-10-04 10:00:03 EDT

Created attachment 204510 [details]
Error dialog describing the problem: WS is in use.

Comment 2 Helmut J. Haigermoser

2011-10-04 10:00:28 EDT

CQ:WIND00188567

Setting Eclipse version to 3.7, adding attachment.

Comment 3 Remy Suen

2011-11-18 13:39:22 EST

Makes sense to me. Helmut, would you be able to contribute a patch for this?

Comment 4 Helmut J. Haigermoser

2011-11-25 06:17:22 EST

Created attachment 207525 [details]
proposed patch to address this issue

Here is a proposed patch, it's my first using git so let me know if I did this right, here is my workflow:
1.) clone git repo (git://git.eclipse.org/gitroot/platform/eclipse.platform.ui.git/)
1.1) I only cloned the master branch, hope that's right
2.) Create a fix, it's merely an NLS change adding the workspace location to the message text
3.) Check in the fix to my local clone
4.) Use e-git to create a patch from the commit

Let me know what you think...
Helmut

Comment 5 Oleg Besedin

2011-11-25 10:29:54 EST

Hi Helmut, 
Thanks for the patch, your Git workflow is what we use too ( http://wiki.eclipse.org/EGit/User_Guide#Creating_Patches ), I guess it is as good as it gets.

For the patch, there are two error messages - one used on restart (that's the one you updated) and one used in initial startup. From the description, it seemed that you were more interested in the startup case, so I updated that one as well.

Changes released in Git 3.8:
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R3_development&id=52ed8db064ace7c83cff1ad6f046f3fba1f2fc03

and 4.2:
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b7d1f7d2265b33124651890f1c3edf71e5b5280d

Thanks for the patch!

Comment 6 Helmut J. Haigermoser

2011-11-25 10:32:51 EST

(In reply to comment #5)
> Hi Helmut, 
> Thanks for the patch, your Git workflow is what we use too (
> http://wiki.eclipse.org/EGit/User_Guide#Creating_Patches ), I guess it is as
> good as it gets.
> 
> For the patch, there are two error messages - one used on restart (that's the
> one you updated) and one used in initial startup. From the description, it
> seemed that you were more interested in the startup case, so I updated that one
> as well.
> 
> Changes released in Git 3.8:
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R3_development&id=52ed8db064ace7c83cff1ad6f046f3fba1f2fc03
> 
> and 4.2:
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b7d1f7d2265b33124651890f1c3edf71e5b5280d
> 
> Thanks for the patch!

Thank you Remy for going through the effort with me! :)
Helmut

Comment 7 Helmut J. Haigermoser

2011-11-25 10:33:34 EST

> Thank you Remy for going through the effort with me! :)
> Helmut
Oleg and Remy that should have been, sorry ...
Helmut