Bug 359768

Comment 1 Huang Ji Yong 2011-10-09 00:56:08 EDT

Created attachment 204816 [details]
Selection Page of Dependency

Comment 2 Huang Ji Yong 2011-10-09 00:57:01 EDT

(In reply to comment #0)
> The UI intentionally doesn't let me deselect the standard widgets, but there is
> no visible indicator as to why. If you disable/gray out the row then I will
> know that it can't be deselected, but right now it looks like a bug when it
> doesn't deselect.
> 
> Also - why *can't* I deselect it? What if I'm using 100% Dojo and don't need
> the dependency? Why not just require that at least one library be selected?

Hi Justin,
You cannot use 100% Dojo because Dojo depends on RUI widgets. The RUI widgets are required to be always checked in “Bug 356967 - Should not be able to uncheck Rich UI widgets on EGL Settings”

Anyway, I agree that user should be able to deselect RUI widgets in case that there is a user defined library which does not depend on RUI widgets.

I have a proposal:
1. User can deselect any widget libraries. By that means, user can create a Web client project without depending on any widget libraries. (This is different with bug 356967 which says RUI widget should always be selected)
2. Add dependency to the widget library extension point (dependentLibs). When implementing the extension point, developer can specify one or more dependent libraries for the new library. (In this case, all dojo widgets depends on RUI widgets and should be specified in the extension point)
3. In the library selection page, when user select a library, the library's dependent library will automatically selected (when selecting Dojo, RUI will be selected). On the other hand, when deselect a library, the other libraries depending on it will be deselected automatically.

I attach a patch to demonstrate the library selection page after applying this proposal. Feel free to play with it.

Will & Theresa, do you have any comments?
Thanks.

Comment 3 Theresa Ramsey 2011-10-11 16:12:38 EDT

Reasons we didn't allow users to deselect the RUI widgets was 1) Dojo depended on RUI, 2) at the time, we didn't want to put in dependency logic (though apparently the patch has it), 3) users might not understand why they can't use some of the RUI widgets that aren't the palette.

JiYong, can you double check what/how the Dojo widgets depend on RUI widget? Ideally, we hoped to remove any dependency on each other.  Though, would any new widget set likely depend on the RUI widgets too?  

For now, perhaps an easier solution is to select/check and disable the RUI widget project so that it's clear that it can't be removed from a RUI project.

Comment 4 Huang Ji Yong 2011-10-11 23:24:52 EDT

*** Bug 358326 has been marked as a duplicate of this bug. ***

Comment 5 Huang Ji Yong 2011-10-12 01:31:33 EDT

Hi Theresa,
I think I was wrong. Dojo widgets do NOT depend on RUI widget and can be used alone without RUI widgets. Please ignore comment2.
 
I agree that we should disable the RUI widget project checkbox.
Fan will do the change.
Thanks for your comment.

(In reply to comment #3)
> Reasons we didn't allow users to deselect the RUI widgets was 1) Dojo depended
> on RUI, 2) at the time, we didn't want to put in dependency logic (though
> apparently the patch has it), 3) users might not understand why they can't use
> some of the RUI widgets that aren't the palette.
> 
> JiYong, can you double check what/how the Dojo widgets depend on RUI widget?
> Ideally, we hoped to remove any dependency on each other.  Though, would any
> new widget set likely depend on the RUI widgets too?  
> 
> For now, perhaps an easier solution is to select/check and disable the RUI
> widget project so that it's clear that it can't be removed from a RUI project.

Comment 6 Song Fan 2011-10-25 02:31:52 EDT

Created attachment 205876 [details]
Fix Patch

Comment 7 Huang Ji Yong 2011-10-28 05:49:03 EDT

Code Committed

Comment 8 Song Fan 2011-10-30 22:43:04 EDT

fixed

Comment 9 Justin Spadea 2011-10-31 15:44:53 EDT

Verified - it's much more obvious now that it can't be deselected.