Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359704

Summary: SystemEditableRemoteFile does not release reference to editor
Product: [Tools] Target Management Reporter: Violaine Batthish <batthish>
Component: RSEAssignee: David McKnight <dmcknigh>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: dmcknigh
Version: 3.2.2   
Target Milestone: 3.4 M3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 359860    
Attachments:
Description Flags
patch to release editor from SystemEditableRemoteFile on close none

Description Violaine Batthish CLA 2011-10-03 09:04:49 EDT 
While investigating a memory leak when opening and closing my editor, I found that when opening a file from the RSE tree view, SystemEditableRemoteFile saves a reference to the open editor (in variable editor), but when the editor is closed, that reference in SystemEditableRemoteFile is not set to null and garbage collection is not able to clear up all the memory that the editor had consumed.

A fix is needed for RSE 3.2 maintenance.
Comment 1 David McKnight CLA 2011-10-03 10:22:58 EDT 
Created attachment 204450 [details]
patch to release editor from SystemEditableRemoteFile on close

Violaine, can you see if this patch helps?
Comment 2 Violaine Batthish CLA 2011-10-04 11:14:50 EDT 
(In reply to comment #1)
> Created attachment 204450 [details]
> patch to release editor from SystemEditableRemoteFile on close
> 
> Violaine, can you see if this patch helps?

Hi Dave,  yes this patch seems to do the trick.  I can see my editor resources being freed now.
thanks, Violaine
Comment 3 David McKnight CLA 2011-10-04 11:30:51 EDT 
I've committed the fix to the HEAD stream and opened bug 359860 for the R3_2_maintenance stream backport.