Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359702

Summary:	[compare] Diff URIs may have parameters and compare container does not respect it
Product:	[ECD] Orion	Reporter:	Szymon Brandys <Szymon.Brandys>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	libingw
Version:	unspecified
Target Milestone:	0.3 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Szymon Brandys

2011-10-03 08:51:31 EDT

This is the case:
I have my own custom diff URI. It has parameters and looks similar to this /myDiff?beforeStateId=...
The problem is that CompareContainer#resolveDiff from compare-container.js cuts off these parameters what is wrong. The compare container method should not change diff uris and just use them as they are.

Comment 1 Szymon Brandys

2011-10-03 09:10:14 EDT

We need to get rid of diffURI = params[0]; in compare-container.js line 99.

Comment 2 libing wang

2011-10-03 10:31:53 EDT

fixed with

Comment 3 libing wang

2011-10-03 10:35:27 EDT

fixed with 75a35817dc90771cfb34eea9d8785ae765f1e958.
We are using compare.html?conflict#diffURI now. (also tested other options like : compare.html?readonly#diffURI , compare.html?readonly&conflict#diffURI)

Comment 4 Szymon Brandys

2011-10-03 10:50:33 EDT

Thanks!