Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359668

Summary:	Add ITimeField interface and AbstractTimeColumn class for Framework consistency
Product:	z_Archived	Reporter:	Jeremie Bresson <dev>
Component:	Scout	Assignee:	Project Inbox <scout.core-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	minor
Priority:	P3	CC:	dev, ivan.motsch
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Jeremie Bresson

2011-10-02 17:28:28 EDT

Build Identifier: 

Scout has a very consistent architecture: IXxxxField interface has a main interface: AbstractXxxx class.

I identified two missing class/interface:
* org.eclipse.scout.rt.client.ui.form.fields.datefield.ITimeField
Should be an interface (maybe just a marker interface) for Field representing Time (see: AbstractTimeField)

* org.eclipse.scout.rt.client.ui.basic.table.columns.AbstractTimeColumn
There is no Main Class for the column type time (like AbstractStringColumn). It would be good to have main implementation for class implementing ITimeColumn.


Reproducible: Always

Comment 1 Ivan Motsch

2011-10-17 11:39:05 EDT

Date, Time, and DateTime all all subsummarized under IDateField and IDateColumn.

The only difference between these 3 types is the setting of the property getConfiguredHasTime and getConfiguredHasDate.

The interface 
org.eclipse.scout.rt.client.ui.basic.table.columns.ITimeColumn
shound be deleted since this was forgotten when these 3 types were unified. 

That would leave us with the core types IDateField, AbstractDateField
and IDateColumn, AbstractDateColumn.

For convenience AbstractDateTimeField and AbstractTimeField already exist.

What is therefore missing is AbstractDateTimeColumn and AbstractTimeColumn.

Summary: 
1) with the IDateField and its abstract base classes everything is fine.

2) I suggest adding the two convenience classes AbstractDateTimeColumn and AbstractTimeColumn, but no interface for it, since this is the same as IDateColumn.

3) I suggest deleting ITimeColumn since this was simply forgotten in the unification of date/dateTime/time.

Comment 2 Ivan Motsch

2011-10-18 11:28:41 EDT

Fixed consistency issues as described.

Comment 3 Matthias Zimmermann

2012-07-09 06:50:58 EDT

ticket closed.
deliverd as part of eclipse scout 3.8.0 (juno release train)