Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359667

Summary:	[engine] Engine did not get tagged for 3.7.x builds
Product:	[Eclipse Project] Equinox	Reporter:	Pascal Rapicault <pascal>
Component:	p2	Assignee:	P2 Inbox <equinox.p2-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	critical
Priority:	P3	CC:	kane.mx, kane.zhu, remy.suen, tjwatson
Version:	3.7.1
Target Milestone:	3.7.2
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:
Bug Depends on:
Bug Blocks:	359661

Description Pascal Rapicault

2011-10-02 17:01:59 EDT

By a mystery that I can't quite explain, the engine has not been tagged for 3.7.x which means that the fix for bug #350380 did not make it to SR1.

Comment 1 DJ Houghton

2011-10-03 16:59:19 EDT

Tom and I talked about it off-line and I've gone through and manually tagged and released any bundles which have changed in commits since the 3.7.x branch was created. (if the commits contained real changes other than adding a .gitignore, etc)

Note that we will have bundle version errors when the builds are run and compared against 3.7.1.

Comment 2 Meng Xin Zhu

2011-10-08 01:36:37 EDT

'org.eclipse.equinox.p2.ui.importexport' was not tagged as well. I increased the minor version from 0 to 1, but I find the qualifier string of all changed p2 bundles in 3.7.1 starts with 'R37x_'. Should I need change the version to '1.0.1.R37x_qualifier'?

Comment 3 Thomas Watson

2011-10-10 09:19:00 EDT

(In reply to comment #2)
> 'org.eclipse.equinox.p2.ui.importexport' was not tagged as well. I increased
> the minor version from 0 to 1, but I find the qualifier string of all changed
> p2 bundles in 3.7.1 starts with 'R37x_'. Should I need change the version to
> '1.0.1.R37x_qualifier'?

No you should not do that in the manifest of org.eclipse.equinox.p2.ui.importexport.  The qualifier value gets inserted during the build according to the tag used to contribute the fixes for the maintenance stream build.  For maintenance stream contributions we use tags prefixed with R37x_.  DJ, correct me if I am wrong, but I think you did manually tag the importexport project for the 3.7.2 builds (the first build has not happened yet).

Comment 4 Meng Xin Zhu

2011-10-10 23:11:30 EDT

Got it.

Thank you, Thomas.

Comment 5 DJ Houghton

2011-10-11 10:18:50 EDT

Not only will I correct you if you're wrong, I will confirm if you're right. :-) 

Yes, I tagged that importexport bundle last week so it should be picked up in the next 3.7.x build. I don't think I modified the bundle version numbers though so I will review those once the build comes out and we get a chance to run the comparator tool.

Comment 6 DJ Houghton

2011-10-12 09:00:17 EDT

Bundles have been tagged now.
Closing.