| Summary: | EGit Perspective icon looks out of place | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Technology] EGit | Reporter: | Nicolas Bros <nicolas.bros> | ||||||||||
| Component: | UI | Assignee: | Project Inbox <egit.ui-inbox> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||
| Severity: | trivial | ||||||||||||
| Priority: | P3 | CC: | dmgloss, nicolas.bros, remy.suen, tomasz.zarna | ||||||||||
| Version: | 1.2 | ||||||||||||
| Target Milestone: | 2.0 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows 7 | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 204426 [details]
before
Created attachment 204427 [details]
after
Till that day I thought that funny colors on git perspective icon was due to antialiasing or some subpixel cleartype artifacts :) And only now when closely looking at it I see that these colors where intentional. Maybe it would be better to consistently write VCS name with solid black? It is more readable that way. What do you think? Regards. (In reply to comment #3) I thought the color was used to help distinguish the Git perspective. But maybe it is better to have the same color for each of the SCM perspective icons. Either way suits me. Created attachment 214017 [details] change 5588/2 with higher color saturation slight variation of what Robin proposed in https://git.eclipse.org/r/#/c/5588/2 with a higher color saturation in order to increase readability Fixed in c36a295ac32f9c0b0d1323cffbe4c4619169a541 |
Created attachment 204425 [details] git_perspective.gif When I disable "Show Text" for perspectives and look at icons for the CVS, SVN, and EGit perspectives side by side, the EGit icon looks washed out and is offset by one pixel compared to the other icons. See the attached screenshot "before". I propose changing the icon to something more like the attached "gitrepository.gif". Look at the "after" screenshot to see it in context. I found the icon EGit uses for its perspective icon in: org.eclipse.egit.ui/icons/obj16/gitrepository.gif But this icon might be used in other places in EGit. In this case it should probably be copied to a new icon egit_perspective.gif or something like this.