Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359622

Summary:	Postponed Anomalies function does not work properly
Product:	z_Archived	Reporter:	Sebastien Dubois <sebastien.dubois>
Component:	Mylyn	Assignee:	Sebastien Dubois <sebastien.dubois>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	alvaro.sanchez-leon, lmcbout
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows Vista
Whiteboard:

Description Sebastien Dubois

2011-09-30 16:48:45 EDT

There are some problems with the Postponed anomalies function:

- When importing postponed anomalies, the postponed container is disabled by default, even when valid anomalies were imported
- When it is restored, a null pointer exception is sometimes generated

java.lang.NullPointerException
	at org.eclipse.mylyn.reviews.r4e.ui.internal.model.R4EUIPostponedFile.open(R4EUIPostponedFile.java:226)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.model.R4EUIPostponedContainer.open(R4EUIPostponedContainer.java:126)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.commands.RestoreElementHandler$1.runInUIThread(RestoreElementHandler.java:97)
	at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4140)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3757)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
	
	
- The postponed file /postponed anomalies entries could end up duplicated in the model/navigator tree.  Closing/reopening the review does not clear the problem

- When importing psotponed anomalies on the review where they were originally generated, a postponed container and file are created.  This is wrong.  The psotponed container is disabled by default

- Changing the state of the postponed anomaly in the review where it was imported does not change the state in the original review.  It should

Comment 1 Sebastien Dubois

2011-10-25 11:15:32 EDT

After more tests on newest release, it seems that the only problem left is that we cannot disable the postponed container

Comment 2 Sebastien Dubois

2011-10-26 15:05:00 EDT

Another problems that are still occuring:

- The postponed file /postponed anomalies entries could end up duplicated in the model/navigator tree. Closing/reopening the review does not clear the problem.  This happens when we disable the postponed container and then immediately import postponed anomalies

- When the original anomaly state is changed, the postponed anomaly state does not get updated

Comment 3 Sebastien Dubois

2012-03-19 15:55:22 EDT

Fix is implemtented and will be delivered at next release