Bugzilla – Full Text Bug Listing
| Summary: | [client][status] Unstage a group of files. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | libing wang <libingw> | ||||||
| Component: | Git | Assignee: | libing wang <libingw> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | jarthana, mamacdon, simon_kaegi, Szymon.Brandys, tomasz.zarna | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | 0.3 RC2 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | 359578 | ||||||||
| Bug Blocks: | 359404 | ||||||||
| Attachments: |
|
||||||||
|
Description
libing wang
(In reply to comment #0) > At comment 1 in bug 356130, I mentioned that unstaging selected file was > blocked by bug 347776. Given that this bug was fixed, we have to enable the > multiple selection in the staged area now. > In order to support this we need server support first. Is it something for .3? The server side was addressed by Tomek some time ago. Mark, we discussed if Jay can take this. Please comment or reassign to him. Jay was looking for some small stuff to get him acquainted with the Orion JS codebase. I pinged him about Bug 359404. Jay: are you interested/able to look at this bug too? If not, Libing will take it. (In reply to comment #3) > Jay was looking for some small stuff to get him acquainted with the Orion JS > codebase. I pinged him about Bug 359404. > > Jay: are you interested/able to look at this bug too? If not, Libing will take > it. Sure, I will take a look at these both. Created attachment 204740 [details]
Draft patch
Draft version.
The patch could be improved: for instance, the stage all and unstage all checkboxes remain selected but the individual items get deselected. It's an existing one for unstaged section, but can be fixed for both sections.
(In reply to comment #5) > Created attachment 204740 [details] > Draft patch > > Draft version. > > The patch could be improved: for instance, the stage all and unstage all > checkboxes remain selected but the individual items get deselected. It's an > existing one for unstaged section, but can be fixed for both sections. I looked at the bug and tried it. It worked well but the check box was not cleaned well. Bu given that bug 359404 is not fixed yet , this is not a big deal though. I HOPE both bugs will be released in the same time. My fingers didn't follow my mind: I really meant : I Looked at the patch. I hope the fixed to be released, not the bugs. (In reply to comment #7) > My fingers didn't follow my mind: > I really meant : > I Looked at the patch. > I hope the fixed to be released, not the bugs. Did you mean the remaining issues be fixed with the bug #359404 and that I can go ahead and release this patch? (In reply to comment #8) > Did you mean the remaining issues be fixed with the bug #359404 and that I can > go ahead and release this patch? Okay, never mind. I will soon post a patch fixing the bug 359404. Since the fix is dependent on the previous patch, I guess I will make the bug 359404 dependent on this one. Created attachment 204896 [details] Proposed fix In addition to the changes in the previous patch, this patch contains fix for the issues mentioned under bug 359404 as well. Couple of notes on the patch: 1. I was tempted to move the GitStatusTableRenderer.renderAction and updateCheckbox (newly added) in to a single method since they are called under similar circumstances. But in the end kept the changes minimal. 2. There was a bit of inconsistency in selecting/deselecting the stage all check box when things are moved between staged and Unstaged sections. This patch consistently deselects both the stage all and unstage all check boxes. Please let me know if this is not the behavior we prefer. (In reply to comment #10) > Created attachment 204896 [details] > Proposed fix > > In addition to the changes in the previous patch, this patch contains fix for > the issues mentioned under bug 359404 as well. Couple of notes on the patch: > > 1. I was tempted to move the GitStatusTableRenderer.renderAction and > updateCheckbox (newly added) in to a single method since they are called under > similar circumstances. But in the end kept the changes minimal. > > 2. There was a bit of inconsistency in selecting/deselecting the stage all > check box when things are moved between staged and Unstaged sections. This > patch consistently deselects both the stage all and unstage all check boxes. > Please let me know if this is not the behavior we prefer. I looked at the patch and tied it out. I went through several work flows I always had before, works fine for me. +1 from me and I think it is good for RC2. fixed with 5256bd017e9916fcee6f2b69b887a0f404337476. Thanks Jay for fixing this. |