Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359574

Summary: NPE in IndexDiffData seems to have killed the decorators
Product: [Technology] EGit Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Project Inbox <egit.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: jens.baumgart, markus.kell.r, matthias.sohn
Version: 1.1   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Screenshot depicting the state in question. none

Description Remy Suen CLA 2011-09-30 10:56:43 EDT
Created attachment 204391 [details]
Screenshot depicting the state in question.

Eclipse 3.8 I20110927-0800
EGit 1.2.0.201109300915

1. Started Eclipse and it was building my workspace.
2. I canceled that.
3. Went to the 'History' view to checkout a commit from a few weeks ago.
4. Noticed EGit was working because the 'Git Staging' view was open. So I closed it to cancel its indexing job.
5. Some time later I get a bunch of NPEs. And now my projects are "unknown".

java.lang.NullPointerException
	at org.eclipse.egit.core.internal.indexdiff.IndexDiffData.<init>(IndexDiffData.java:81)
	at org.eclipse.egit.core.internal.indexdiff.IndexDiffCacheEntry.calcIndexDiffData(IndexDiffCacheEntry.java:240)
	at org.eclipse.egit.core.internal.indexdiff.IndexDiffCacheEntry.access$6(IndexDiffCacheEntry.java:223)
	at org.eclipse.egit.core.internal.indexdiff.IndexDiffCacheEntry$4.run(IndexDiffCacheEntry.java:189)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Comment 1 Remy Suen CLA 2011-09-30 10:57:58 EDT
(In reply to comment #0)
> 5. Some time later I get a bunch of NPEs. And now my projects are "unknown".

It seems the decorators came back while I was filling out this bug report. :)
Comment 2 Markus Keller CLA 2011-10-13 09:52:50 EDT
The wrong intermediate state of decorators has also been mentioned in bug 333204 comment 19.
Comment 3 Jens Baumgart CLA 2011-10-14 11:34:57 EDT
Fix proposed: http://egit.eclipse.org/r/4350
Comment 4 Matthias Sohn CLA 2011-10-14 17:44:24 EDT
merged as e75924d5a54762ed1916c2f727febb7826b84880