Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359489

Summary:

TitleAreaDialog has a gap below the image in Firefox 6

Product:

[RT] RAP

Reporter:

Arvinder Birdi <arvindersbirdi>

Component:

RWT

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

tbuschto

Version:

1.4

Target Milestone:

1.5 M3

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Modified source file in "RAP Application with a view" Template	none
screen shot of defect	none
Title only, without message: works	none

Description Arvinder Birdi

2011-09-29 17:28:48 EDT

Build Identifier: Build id: 20110615-0604

Titleareadialog works properly in IE9. 

In Firefox extra white space is put below the image. About 14 pixels in my case. The is clearly visible and causes the lower controls to be hidden in our fixed size dialogs.

Reproducible: Always

Steps to Reproduce:
1. Create a titlarea dialog with an image and 4 entry fields, 2 buttons.
2. Compare rendering in IE9 and firefox.
3.

Comment 1 Ivan Furnadjiev

2011-09-30 02:50:31 EDT

Could you provide a self running snippet that demonstrate the problem?

Comment 2 Arvinder Birdi

2011-10-04 10:17:36 EDT

Shell activeShell = PlatformUI.getWorkbench().getDisplay().getActiveShell();

TitleAreaDialog dialog = new TitleAreaDialog(activeShell);
dialog.create();

// Title does NOT affect the problem.
// dialog.setTitle("The Title");

// Setting a message CAUSES the problem.
dialog.setMessage("A message.");
        
dialog.open();

========================================================================
I have tested it on 3 windows 7 (64bit) machines with firefox 7.
It happens on 2 out of 3 of them.

Comment 3 Arvinder Birdi

2011-10-04 15:59:44 EDT

Created attachment 204548 [details]
Modified source file in "RAP Application with a view" Template

File->defect will launch the TitleAreaDialog with the problem.

Comment 4 Arvinder Birdi

2011-10-04 16:02:25 EDT

Created attachment 204549 [details]
screen shot of defect

Comment 5 Arvinder Birdi

2011-10-04 16:07:36 EDT

Created attachment 204550 [details]
Title only, without message: works

Comment 6 Arvinder Birdi

2011-10-04 17:33:05 EDT

I looked at the outline in the browser debugger. 

It looks like the height of the html textarea used to show the message is too large and extends below the image.

Comment 7 Arvinder Birdi

2011-10-05 13:43:14 EDT

This works in RCP.

Comment 8 Arvinder Birdi

2011-10-13 17:20:22 EDT

Problem appears on machines where firefox has gpu acceleration enabled. Use URL "about:support" to check.

Then under Options, Advanced, Browsing:
Unselect "Use hardware acceleration when available" and restart.
This fixes the problem. 

When it is enabled again the problem reappears.

Comment 9 Ivan Furnadjiev

2011-11-04 06:12:31 EDT

For me it is reproducible in all browsers.

Comment 10 Ivan Furnadjiev

2011-11-04 11:28:41 EDT

This was a text size determination issue. TitleAreaDialog has a field messageLabelHeight. Based on this field, which was calculated only once ( in TitleAreaDialog#createTitleArea ), the dialog layout is calculated. Fixed by updating the messageLabelHeight and do layoutForNewMessage in the messageLabel resize event. Changes are in CVS HEAD.