Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359480

Summary: Make outline into a tree
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: ClientAssignee: Susan McCourt <susan>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: john.arthorne, simon_kaegi
Version: 0.3   
Target Milestone: 1.0 M2   
Hardware: PC   
OS: All   
Whiteboard:

Description Mark Macdonald CLA 2011-09-29 16:31:46 EDT
Orion 0.3M2

The styling on the outliner should be improved so that it's easier to distinguish branches from leaves.
Right now it looks like:

 Branch 
     Leaf
     Leaf

But something like this would be better:

 v Branch
    |- Leaf
    |- Leaf

Could also try using a treetable widget rather than simple <ul>s.
Comment 1 Mark Macdonald CLA 2011-09-29 16:36:45 EDT
Also, 'tooltip' property could be added to the outline API so providers can customize the hover message of outline items.
Comment 2 Mark Macdonald CLA 2011-11-17 10:18:21 EST
It should just be a tree widget, like the explorer-tree used by the navigator.
Comment 3 Mark Macdonald CLA 2011-12-06 11:59:41 EST
(In reply to comment #2)
> It should just be a tree widget, like the explorer-tree used by the navigator.

Levels should be collapsible, and the API should let a provider choose a node's initial expand/collapse state to hide uninteresting subtrees by default.
Comment 4 Susan McCourt CLA 2012-09-12 13:29:17 EDT
I'm going to play with this a little bit, because I'm trying to see if I can create an "outliner" that is actually a navigator that would change the hash for the editor page.

First step would be to move the rendering to use explorer-table, and the next step would be to make the select behavior configurable.
Comment 5 Susan McCourt CLA 2012-09-13 14:22:18 EDT
This wasn't too bad at all, and helped to flesh out more assumptions in the explorer widget world.

A couple of things I did not address, as I want to get real world feedback. 
I've opened bugs for the suggestions here that did not go in with the initial fix.

(1) initial expansion behavior.  
(In reply to comment #3)
> Levels should be collapsible, and the API should let a provider choose a
> node's initial expand/collapse state to hide uninteresting subtrees by
> default.
Opened bug 389547 

(2) tooltip for outline items.
Opened bug 389548

I wasn't sure what the keyboard interaction/selection should be like for the outliner now.  Note that before this fix, you can't really cursor through the navigator links with the keyboard, you have to click them.

Now that we are using a navigator, you can cursor through (and expand/collapse) navigator items.  So it seems possible you'd want to just hit enter at that point and go to that spot in the outliner.  However, you'd get a lot of file jumping as you cursored around the tree and I wasn't sure if folks wanted that.  So I'll await user feedback.
Comment 6 Mark Macdonald CLA 2012-09-13 14:36:59 EDT
(In reply to comment #5)
> I wasn't sure what the keyboard interaction/selection should be like for the
> outliner now.  Note that before this fix, you can't really cursor through
> the navigator links with the keyboard, you have to click them.
> 
> Now that we are using a navigator, you can cursor through (and
> expand/collapse) navigator items.  So it seems possible you'd want to just
> hit enter at that point and go to that spot in the outliner.  However, you'd
> get a lot of file jumping as you cursored around the tree and I wasn't sure
> if folks wanted that.  So I'll await user feedback.

I'd like to be able to press Enter to jump to an item. 

Even better would be to combine that with type-to-filter and a keyboard shortcut for focusing the outliner -- then we'd be pretty close to the Quick Outline in Eclipse desktop (which I love for being completely operable with just the keyboard)