Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359430

Summary: Generating just sql-script has unnecessary warning dialog
Product: [WebTools] Dali JPA Tools Reporter: Karen Butzke <karenfbutzke>
Component: JPAAssignee: Tran Le <tranle1>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: neil.hauge
Version: 3.1   
Target Milestone: 3.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Karen Butzke CLA 2011-09-29 10:15:44 EDT
Choose to generate tables for a JPA project and choose 'Sql-script' as the Generation Output Mode. When you click finish a dialog appears warning you that "Generating DLL will DROP existing tables...". This dialog should not appear for just generating the sql-script. The dialog also needs to be changed to reflect that the sql-script will be run and that is what will drop and create new tables.
Comment 1 Neil Hauge CLA 2011-10-18 16:27:55 EDT
(In reply to comment #0)
> The dialog also needs to be changed to
> reflect that the sql-script will be run and that is what will drop and create
> new tables.

Do you have a specific suggestion for this?  Not sure if I see the point of making this distinction, but perhaps an example would clear things up for me.
Comment 2 Karen Butzke CLA 2011-10-19 07:05:10 EDT
I'm not sure what I was saying, I must have confused a word or two! If you choose 'sql-script' there should be no warning dialog. If you choose 'Database' or 'Both' we do need a warning dialog. I think I was trying to say that the warning should say something other than 'Generating DDL...'. Maybe 'Generating tables...' at that point would make more sense.
Comment 3 Neil Hauge CLA 2011-10-19 08:09:16 EDT
Ok.  That sounds reasonable to me.
Comment 4 Tran Le CLA 2011-10-25 20:02:04 EDT
Fixed in M3