Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359370

Summary:

ResourceChangeJob blocks save operation

Product:

[WebTools] WTP ServerTools

Reporter:

Dimitar Giormov <dimitar.giormov>

Component:

wst.server

Assignee:

wst.server <wst.server-inbox>

Status:

NEW ---

QA Contact:

Elson Yuen <eyuen7>

Severity:

normal

Priority:

CC:

naci.dai, vladimir.pavlov

Version:

3.3

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
remove the source rules and optimize job search	none

Description Dimitar Giormov

2011-09-29 05:00:22 EDT

I will explain first our use-case:
We have a server that takes a while to start more than 5 min. And the publish operation happens before the start operation. The issue that we are facing is that we cannot execute more than one save operation of a published file (jsp) while the server is starting.

How to reproduce:

1. have an server that starts a bit slow with publish before start logic.
2. publish and try to start the server.
3. While server is starting try to modify the file and save. First save will be successful, so try again.

Save operation will be blocked until the server starts, so this gets particularly annoying when we are working against several servers.

What happens behind the scenes:
When a change is done on a module that is already published a ResourceChangeListener will launch a ResourceChangeJob with MultiRule Server instance and the Project of the published module. In our usecase at the moment another job is running that is the Start job that has a rule the server instance, so the ResourceChnageJob is blocked by the server lock. On the second save of the editor a check is done that the resource is not blocked by a running or a waiting job.

Comment 1 Dimitar Giormov

2011-09-29 05:06:31 EDT

Created attachment 204269 [details]
remove the source rules and optimize job search

Now I will explain a bit about my research on the topic.

After some time in code browsing I could not find the reason why the resource is blocked during the ResourceChangeJob, the resource is used only for the check that if an already published resource is changed the flag should be updated to republish. So basically only the project is required to complete the operation.

Thus I created a patch where this logic is removed.

Looking forward for your feedback.

best regards,
Dimitar

Comment 2 Dimitar Giormov

2011-10-11 03:36:53 EDT

Hi again,

can someone comment on this?

best regards,
Dimitar

Comment 3 Naci Dai

2011-10-29 15:48:30 EDT

I am not sure if this bug is the right place to discuss this but we have a different problem, which is also related;  In Libra OSGi server adapters a publish is required to finis befıre a server start job.  I think we need an extension mechanism to implement alternate start/publish behaviors for some servers.  Please see  Bug 362393 for more detail.

We are testing different approaches to implement this with minimal impact.

Comment 4 Dimitar Giormov

2011-10-31 10:40:00 EDT

Hi Naci,

we had the same problem for start and publish. It will be great if this can be done from the framework.
However, this bug is for the same server type that publishes and then starts.
Here the issue is that the resource change job is blocking the save operation.
Though we do not see why the resource change job has to block the resource.

Best regards,
Dimitar