Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359352

Summary: The customized HTML widget cannot be displayed in outline view
Product: z_Archived Reporter: fahua jin <jinfahua>
Component: EDTAssignee: Huo Zhen Zhong <huozz>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: chenzhh, greer, huozz, svihovec
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
The sample project.
none
The screen-shot.
none
test case 2 none

Description fahua jin CLA 2011-09-29 03:30:23 EDT
Build Identifier: 0.7.0.v201109282102

1) Open the BorderContainer.egl in attached project with RUI handler with VE.
2) The outline view should show the hierarchy tree of the component. Please refer to the attached picture for the detailed information.

 

Reproducible: Always
Comment 1 fahua jin CLA 2011-09-29 03:31:24 EDT
Created attachment 204255 [details]
The sample project.
Comment 2 fahua jin CLA 2011-09-29 03:32:07 EDT
Created attachment 204256 [details]
The screen-shot.
Comment 3 Huo Zhen Zhong CLA 2011-10-24 01:57:47 EDT
It use new Div{}, blocked by 359165
Comment 4 Brian Svihovec CLA 2011-10-24 10:09:42 EDT
I looked at the Handler in this project, and it contains:

top Div = new Div{};

While I agree that this code needs to be handled correctly by the VE Outline in the future, I don't believe that this issue is a high priority at this time.  

I do not believe that this issue is a high priority because the EGL source, while technically correct, is not something we would recommend as a best practice.  In the line mentioned above, a new Div is first created and assigned to 'top', next, a second Div is created and assigned to 'top', resulting in the initial Div being thrown away. The recommended approach would be:

top Div{};

Note that since there is no '?', the variable is treated as a 'value', and a new Div is instantiated immediately, followed by the processing of the settings block.  If a '?' had been used, a 'new' would be required:

top Div? = new Div{};

If you are seeing an issue with the outline view when using either:

top Div{};

or 

top Div? = new Div{};

then this issue can be raised to a high severity and priority for .7.
Comment 5 Huo Zhen Zhong CLA 2011-10-25 05:58:51 EDT
Created attachment 205899 [details]
test case 2
Comment 6 Huo Zhen Zhong CLA 2011-10-25 06:04:15 EDT
Hi, Brian

I tried top Div? = new Div{};, and the problem is also occurs, see attached test case 2.

Rocky said the defect is not important, so I did not investigate into it.
Comment 7 Brian Svihovec CLA 2011-11-16 10:23:28 EST
I retried the testcase in comment 5, and it looks like things are rendering correctly.  Please re-try this and provide additional information if things are still not working as you would expect.
Comment 8 Lisa Lasher CLA 2011-11-16 16:40:25 EST
if this is not already fixed, then it is being deferred.  If you retest and it is fixed, then resolve, and reset target to 070 final
Comment 9 Brian Svihovec CLA 2011-12-16 11:38:05 EST
Closing as working as designed.  When something is created dynamically, it should not be editable in the VE:

top Div? = new Div{};

If you do not agree, please reopen this defect.