Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359311

Summary:

[hotbug] RuntimeException: IJSFFacetInstallDataModelProperties.WEBCONTENT_DIR not located with the jsf Facet Configuration disabled

Product:

[WebTools] Java Server Faces

Reporter:

Gloria Yadira Torrealba Melendez <gloriay>

Component:

Assignee:

Ian Trimble <ian.trimble>

Status:

RESOLVED FIXED

QA Contact:

Severity:

major

Priority:

CC:

atomitl, ccc, raghunathan.srinivasan

Version:

3.2.5

Target Milestone:

3.2.5

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Adding a new check to avoid the RuntimeException	none

Description Gloria Yadira Torrealba Melendez

2011-09-28 17:43:39 EDT

Build Identifier: M-3.2.5-20110922064510

When the jsfFacetConfigurationEnabled field is false it produces a RuntimeException during a JSF project creation because the WEBCONTENT_DIR property does not exist (this property is created only when the jsfFacetConfigurationEnabled is true), the propertyChanged method located in the JSFFacetInstallPage class tries to set a value to this property without checking if the property exists. 

Proposed solution is to add a check for JsfFacetConfigurationUtil.isJsfFacetConfigurationEnabled()
in the propertyChanged before trying to set the WEBCONTENT_DIR property.


Reproducible: Always

Steps to Reproduce:
it does not fail on WTP  but is making a consuming product fail because it is not using the jsfFacetConfigurationEnabled.

Comment 1 Gloria Yadira Torrealba Melendez

2011-09-28 17:45:30 EDT

Created attachment 204227 [details]
Adding a new check to avoid the RuntimeException

Comment 2 Carl Anderson

2011-09-28 21:58:35 EDT

IBM is asking that this bug be addressed in the WTP 3.2.5 timeframe.  This bug is causing our adopter product to fail, as per Gloria's description.  We have provided a patch and would like it reviewed and committed/released.

Comment 3 Raghunathan Srinivasan

2011-09-28 23:24:03 EDT

We will review and target the M build on 10/7

Comment 4 Ian Trimble

2011-10-03 16:50:45 EDT

Committed to 3.2.5 stream at 2011/10/03 01:50PM PDT.

Comment 5 Ian Trimble

2011-10-03 17:01:25 EDT

Committed to HEAD (3.4 stream) at 2011/10/03 01:58PM PDT.