Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359310

Summary:	NPE writing the state when weaving hooks are present
Product:	[Eclipse Project] Equinox	Reporter:	Thomas Watson <tjwatson>
Component:	Framework	Assignee:	Thomas Watson <tjwatson>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	alasdair
Version:	3.7
Target Milestone:	3.7.2
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	359294
Bug Blocks:

Description Thomas Watson

2011-09-28 17:25:32 EDT

Clone bug to fix in 3.7.2

+++ This bug was initially created as a clone of Bug #359294 +++

Build Identifier: org.eclipse.osgi_3.7.0.v20110613

Exception in thread "State Saver" java.lang.NullPointerException
        at org.eclipse.osgi.internal.resolver.StateWriter.writeImportPackageSpec(StateWriter.java:599)
        at org.eclipse.osgi.internal.resolver.StateWriter.writeStateWire(StateWriter.java:532)
        at org.eclipse.osgi.internal.resolver.StateWriter.writeList(StateWriter.java:521)
        at org.eclipse.osgi.internal.resolver.StateWriter.writeMap(StateWriter.java:490)
        at org.eclipse.osgi.internal.resolver.StateWriter.writeBundleDescriptionLazyData(StateWriter.java:344)
        at org.eclipse.osgi.internal.resolver.StateWriter.saveState(StateWriter.java:112)
        at org.eclipse.osgi.internal.resolver.StateObjectFactoryImpl.writeState(StateObjectFactoryImpl.java:439)
        at org.eclipse.osgi.internal.baseadaptor.StateManager.writeState(StateManager.java:178)
        at org.eclipse.osgi.internal.baseadaptor.StateManager.update(StateManager.java:116)
        at org.eclipse.osgi.internal.baseadaptor.BaseStorage.saveStateData(BaseStorage.java:661)
        at org.eclipse.osgi.internal.baseadaptor.BaseStorage.saveAllData(BaseStorage.java:458)
        at org.eclipse.osgi.internal.baseadaptor.BaseStorage$StateSaver.run(BaseStorage.java:1304)
        at java.lang.Thread.run(Thread.java:680)

This doesn't seem to cause a huge issue but it causes unsightly worrying messages in log files

Reproducible: Sometimes

Steps to Reproduce:
I haven't been able to reliably introduce this. I've tried with a clean and dirty work area and I've tried several different methods. I can reproduce but not reliably.

Comment 1 Thomas Watson

2011-09-28 17:36:10 EDT

Fix and testcase released in the following commit:

http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?h=R3_7_maintenance&id=5631c65292ce01f0b6f6508d1bcb14a7a8195906