Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359161

Summary: Convert to widget type by "as widget" causes runtime error
Product: z_Archived Reporter: Huang Ji Yong <hjiyong>
Component: EDTAssignee: Project Inbox <edt.javascriptgen-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: greer
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Huang Ji Yong CLA 2011-09-27 21:44:51 EDT 
The test case:
package client;

// RUI Handler

import org.eclipse.edt.rui.widgets.Div;

//
//

handler testAsWidget type RUIhandler{initialUI =[div], onConstructionFunction = start, cssFile = "css/testBugs.css", title = "testAsWidget"}

//   	div Div{ children = [new Div {innerText = "my inner div"} ]};
	div Div{ children = [new Div {innerText = "my inner div"} as Widget ]};
    function start()
    end
end

The generated js for the line of as Widget is
this.div.setChildren([egl.eglx.ui.rui.Widget.fromWidget(eze$Temp1,"Torg/eclipse/edt/rui/widgets/Div;")].setType("Teglx/ui/rui/Widget;"));
In which, fromWidget is not defined at egl.eglx.ui.rui.Widget.

The Shadow widget suffers from this defect. We can have a workaround for Shadow, so mark this defect as normal.
Comment 1 Scott Greer CLA 2011-09-28 15:14:35 EDT 
Caused by a dubious conversion defined in Widget.egl:

	static function asWidget(value Widget in) returns(Widget) {@Operation{"widen"}};


We're afraid this may be necessary due to some quirk or limitation in the type infrastructure, so I'm leaving it in place and have added a no-op implementation to the JS runtime;  I've flagged it with a TODO to question the need for this (non-)conversion and remove it -- and my impl. -- if appropriate.
Comment 2 Huang Ji Yong CLA 2011-10-21 00:42:55 EDT 
Verified in 201110202102