Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359160

Summary:	Outline Selector should have a label
Product:	[ECD] Orion	Reporter:	John J. Barton <johnjbarton>
Component:	Client	Assignee:	Mark Macdonald <mamacdon>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	mamacdon
Version:	0.3
Target Milestone:	0.3 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description John J. Barton

2011-09-27 21:40:37 EDT

1) Install http://johnjbarton.github.com/outliner/nonymousPlugin.html
2) Select it from the drop down on the editor page
3) reload

Your selection is forgotten.

The selector arrow needs a label or at least a tooltip.

Integration build 9/27

Comment 1 Mark Macdonald

2011-09-28 09:24:54 EDT

The outliner is remembered using the 'id' attribute [1] of the service registration. See [2] for an example.
Add an 'id' to nonymousPlugin, reinstall the plugin, and it should be remembered correctly.


[1] http://wiki.eclipse.org/Orion/Documentation/Developer_Guide/Plugging_into_the_editor#Service_attributes_5
[2] http://mamacdon.github.com/outliner/outlinerPlugin.html

Comment 2 Mark Macdonald

2011-09-28 10:48:48 EDT

(In reply to comment #0)
> The selector arrow needs a label or at least a tooltip.

Added a label on the menu:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f7dfeafc4422808cc513e7d56c3366eb039316fb

Comment 3 John J. Barton

2011-09-28 12:31:45 EDT

This change is only partly successful.

After I added the id I had to reload and navigate back and forth a few times even to see the drop down arrow menu. When I did, then I can select my outliner and it works. 

But when I reload the outline panel is empty. The drop down arrow menu show my plugin selected but the outline is empty. Reselecting the item restores the outline.

I see two errors
"NetworkError: 401 Unauthorized - http://blog.johnjbarton.com:8080/prefs/user/window/favorites"
"NetworkError: 401 Unauthorized - http://blog.johnjbarton.com:8080/prefs/user/edit/outline"

Not I am not logining in, I am using the Demo instructions on 
https://github.com/johnjbarton/outliner

jjb

Comment 4 John J. Barton

2011-09-28 12:32:54 EDT

(In reply to comment #3)
> This change is only partly successful.

I meant "The suggestion in comment 1"

Comment 5 John J. Barton

2011-09-28 13:40:03 EDT

Actually I think there is a completely different bug: I don't think the Reload button works on the plugins page. 

I believe this issue is fixed, thanks!

Comment 6 Mark Macdonald

2011-09-28 14:38:21 EDT

(In reply to comment #5)
> Actually I think there is a completely different bug: I don't think the Reload
> button works on the plugins page. 

What you described above sounds like Bug 340964.

When you aren't logged in, Orion should give you the default set of plugins, which means the outline drop-down should not appear at all, since only the default Orion outline provider is installed. 

That's the expectation. But what actually happens when I try this by logging out "mamacdon", is that his user data remains in the browser's localStorage. When the non-logged-in user loads the editor (using the same browser), he gets mamacdon's plugin and preference info. This can cause a bunch of weird stuff to happen.