Bugzilla – Full Text Bug Listing
| Summary: | [Table] Typo in expression with property tester causing issues with handler enablement | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Alain Le Guennec <alain.leguennec> | ||||
| Component: | EMF-Facet | Assignee: | Nicolas Bros <nicolas.bros> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | major | ||||||
| Priority: | P2 | CC: | eclipse-bugzilla, emft.facet-inbox, gdupe, nicolas.bros | ||||
| Version: | unspecified | Flags: | gdupe:
kepler+
|
||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Created attachment 204119 [details]
Patch to fix the issue.
Thank you for this bug. Fixed in revisions 893 & 895 on trunk and branch 0_1. Actually, my patch was slightly wrong: To test against the "activePart" property, one should not use property tester "org.eclipse.emf.facet.widgets.nattable.workbench.tableSelectionTester.isTable", but "org.eclipse.emf.facet.widgets.nattable.workbench.tablePartTester.isTableEditor", otherwise expression evaluation will fail with some CoreExceptions being raised.. Sorry for misleading you with a wrong patch. The fix seems to work for me: I don't see any error and the "Load Facet" action is enabled when the table editor is active. What do you do to trigger a CoreException? Comment on attachment 204119 [details]
Patch to fix the issue.
This patch has been committed by Nicolas Bros.
I've to close this bug to be able to the contribution in the IP log. If needed, please, open another bug. |
There seems to be a typo in org.eclipse.emf.facet.widgets.nattable/plugin.xml in the enableWith expression for the loadFacetCommand handler: It currently reads: property="org.eclipse.emf.facet.widgets.nattable.workbencattable.workbench.tableSelectionTester.isTable" ^^^^^^^^^^^^^^^ The strange "workbencattable" part should be removed. Otherwise, this cause the right property tester not to be found.