Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359131

Summary:

Fixing the dual-monitor issue has broken two tests

Product:

[Eclipse Project] Platform

Reporter:

Eric Moffatt <emoffatt>

Component:

Assignee:

Platform-UI-Inbox <Platform-UI-Inbox>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

remy.suen

Version:

4.2

Target Milestone:

4.2 M3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Change the tests to ensure the modelled window has both a width and height	none

Description Eric Moffatt

2011-09-27 15:21:11 EDT

testWindow_X and testWindowY are broken now. This is the result of the fix for bug 358627. I've added code to force the shell back into the display if the following test fails:

modelBounds.intersects(displayBounds)

Unfortunately it appears that rectangles that have zero width and zero height don't 'intersect' anything...

Comment 1 Eric Moffatt

2011-09-27 15:31:35 EDT

Created attachment 204115 [details]
Change the tests to ensure the modelled window has both a width and height


Remy, take a look. If you think that these changes invalidate the tests then let's talk about it, I could likely come up with logic that doesn't need 'intersects' if we think it's an issue...

Comment 2 Remy Suen

2011-09-27 16:17:43 EDT

(In reply to comment #1)
> Created attachment 204115 [details]
> Change the tests to ensure the modelled window has both a width and height

This looks okay to me.

Comment 3 Eric Moffatt

2011-09-27 16:19:50 EDT

Pushed in >20110927.

commit c7d2276fad5ddc346e18590c8db21f269165d00c

Comment 4 Eric Moffatt

2011-10-26 13:42:27 EDT

Verified in I20111025-2000.