| Summary: | [Compatibility] Separators don't show up for .ecorediagram files | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Remy Suen <remy.suen> |
| Component: | UI | Assignee: | Paul Webster <pwebster> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | curtis.windatt.public, pwebster |
| Version: | 4.2 | ||
| Target Milestone: | 4.2 M7 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 331377 | ||
The SeparatorRenderer is not capable of handling incremental additions. When a separator is appended to the end of the list, it interprets itself as the final separator and as a result does not need to be rendered. While this logic is valid for this single operation, the assumption becomes void once another non-separator item is appended at the end. Now that there _is_ another item between the separator and the end, the separator _needs_ to be rendered. Even if I change the renderer to create separators they don't seem to be showing up in the UI so maybe I'm barking up the wrong tree. This is not fixed using the latest UI code from master and e4.tools 0.10.0.20120203135. Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9cba02d229d5a37228f7387319c28179ce25785a I opened bug 377961 for the layout issue PW Verified in I20120430-1800 Bug 377961 is still a problem |
When a .ecorediagram file is opened, there should be several separators in the main toolbar. They are not being rendered right now. See attachment 203658 [details] for reference.