Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359044

Summary:	Migrate Tycho to current maven-surefire
Product:	z_Archived	Reporter:	Stanislav Ochotnicky <sochotnicky>
Component:	Tycho	Assignee:	Project Inbox <tycho-inbox>
Status:	CLOSED DUPLICATE	QA Contact:
Severity:	normal
Priority:	P3	CC:	akurtakov, jan.sievers
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description Stanislav Ochotnicky

2011-09-27 07:54:32 EDT

Beginning with version 0.13.0, tycho started using "Surefire" class from maven-surefire 2.4.3. This class was stripped down and finally removed in later versions of surefire. internally replaced with class SurefireStarter with considerably different (and cleaner) api. 

I am working on updating tycho to latest surefire (2.9.x) and for now I am stuck with OsgiSurefireBooter class using Surefire. 

OsgiSurefireBooter seems to do a few things that will need to be preserved:
 * use properties from "testproperties" file argument
 * use two distinct classloaders (surefire and test/bundle classloader)
 * honor test includes/excludes specified in properties
 * use same report generators if possible, while also honoring report directory
 * honor "failifnotests" property

Otherwise it's about running surefire provider on included test files as I understood the code.

Comment 1 Jan Sievers

2011-09-27 08:35:23 EDT

before you do anything more in this direction, I strongly recommend to read bug 353222  . Basically what you are trying to do has already been done.

If you plan to do significant work on tycho, it helps to ask on tycho-dev@eclipse.org first so we avoid duplication.

Comment 2 Stanislav Ochotnicky

2011-09-27 08:51:40 EDT

I read through open tycho bugs obviously and I wouldn't guess from bug 353222 summary that fix would include updating to latest surefire. I was planning to mail tycho-dev later today, but I guess you saved me the work so: thank you a lot.

Closing as duplicate.

*** This bug has been marked as a duplicate of bug 353222 ***