Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359038

Summary:	Allow to copy commit hash via context menu > Copy
Product:	[Technology] EGit	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Dani Megert <daniel_megert>
Status:	VERIFIED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	daniel_megert, markus.kell.r, matthias.sohn, remy.suen
Version:	1.1
Target Milestone:	1.3
Hardware:	All
OS:	All
Whiteboard:

Description Dani Megert

2011-09-27 06:51:07 EDT

1.1.0.201109151100-r.

I can copy the commit hash from the Commit Editor or from the History view via keyboard but not via mouse. As a mouse user I'd like to be able to do right mouse click > Copy.

Comment 1 Dani Megert

2011-11-23 04:54:17 EST

Pushed http://egit.eclipse.org/r/4669 for review.

Comment 2 Markus Keller

2011-12-05 05:33:57 EST

Re enablement problems discussed in http://egit.eclipse.org/r/#change,4669 :
This is not Mac-specific.

Steps to reproduce are:
- select the SHA
=> Copy is enabled (good)
- click into Message field
- right-click the title field
=> Copy enabled (should be disabled)

The problem is that HeaderText(Form, String) contains
			titleLabel.addFocusListener(new FocusAdapter() {
				public void focusLost(FocusEvent e) {
					titleLabel.setSelection(0);
				}
			});

This changes the selection without notifying selection listeners.

Comment 3 Dani Megert

2011-12-05 06:00:25 EST

(In reply to comment #2)
> Re enablement problems discussed in http://egit.eclipse.org/r/#change,4669 :
> This is not Mac-specific.
> 
> Steps to reproduce are:
> - select the SHA
> => Copy is enabled (good)
> - click into Message field
> - right-click the title field
> => Copy enabled (should be disabled)
> 
> The problem is that HeaderText(Form, String) contains
>             titleLabel.addFocusListener(new FocusAdapter() {
>                 public void focusLost(FocusEvent e) {
>                     titleLabel.setSelection(0);
>                 }
>             });
> 
> This changes the selection without notifying selection listeners.

Thanks for checking.

Comment 4 Matthias Sohn

2012-01-20 19:27:45 EST

merged as 5922341006cdaffcf83f034cb6bbb063ae499ee6

Comment 5 Dani Megert

2012-01-23 03:31:59 EST

Verified in org.eclipse.egit.ui_1.3.0.201201221914.