Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 359008

Summary:

Remove Spring dependencies from the GW package artifact

Product:

[RT] Gemini.Web

Reporter:

Violeta Georgieva <milesg78>

Component:

unknown

Assignee:

Violeta Georgieva <milesg78>

Status:

CLOSED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

glyn.normington

Version:

2.0.0.RELEASE

Target Milestone:

2.1.0.M01

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch proposal	glyn.normington: review+

Description Violeta Georgieva

2011-09-27 02:52:18 EDT

Check whether Spring dependencies are necessary and if not remove them from the final GW package artifact

Comment 1 Violeta Georgieva

2011-10-19 07:43:29 EDT

org.eclipse.gemini.web.tomcat.internal.loading.BundleWebappClassLoader depends on org.springframework.osgi.util.BundleDelegatingClassLoader.
Because of this dependency additional 5 bundles are needed for successful resolution.
If we remove this dependency, we can drop GW dependency on Spring and thus reduce the package size of the GW distribution.

Comment 2 Violeta Georgieva

2011-10-24 06:40:47 EDT

Created attachment 205796 [details]
Patch proposal

It appears that Eclipse Gemini Blueprint provides bundle delegating classloader functionality and we can use it.
I made a patch. Could you please review it?
With that patch we can remove the following bundles from GW distro:
- org.springframework.aop
- org.springframework.beans
- org.springframework.context
- org.springframework.core
- com.springsource.org.apache.commons.logging
- com.springsource.org.aopalliance

Comment 3 Glyn Normington

2011-10-24 06:49:57 EDT

Comment on attachment 205796 [details]
Patch proposal

The copyright statements of BundleDelegatingClassLoader.java and BundleDelegatingClassLoaderTest.java should have their date ranges updated to end in 2011.

Also, it is the normal Virgo and GW convention to name testcases ...Tests.java although I notice that this hasn't been adhered to uniformly.

Please remember to mark the relevant CQs, such as 4336, as no longer needed if necessary. (I'll send email to Wayne on this topic and copy you.)

Comment 4 Violeta Georgieva

2011-10-24 13:34:07 EDT

(In reply to comment #3)
> Comment on attachment 205796 [details]
> Patch proposal
> The copyright statements of BundleDelegatingClassLoader.java and
> BundleDelegatingClassLoaderTest.java should have their date ranges updated to
> end in 2011.
I corrected them.

> Also, it is the normal Virgo and GW convention to name testcases ...Tests.java
> although I notice that this hasn't been adhered to uniformly.
I corrected the test's name for this particular testcase, the rest will be covered with: Bug 361836

> Please remember to mark the relevant CQs, such as 4336, as no longer needed if
> necessary. (I'll send email to Wayne on this topic and copy you.)
I will do that.

The change is tested, committed and pushed.
Commit Id: cf436ee379ca60e8ed8326f882e8e0f7db0b14b0

Thanks