Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358979

Summary:	[github] Include commit comments in pull request comments list
Product:	[Technology] EGit	Reporter:	Robert Munteanu <robert.munteanu>
Component:	GitHub	Assignee:	Kevin Sawicki <kevin>
Status:	ASSIGNED ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	caniszczyk, kevin, matthias.sohn, zanetu
Version:	1.1
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description Robert Munteanu

2011-09-26 18:16:00 EDT

Opening https://github.com/mantisbt/mantisbt/pull/15 in the web interface shows three comments, but the task editor only shows the second and third one.

Comment 1 Chris Aniszczyk

2011-09-26 18:16:34 EDT

Kevin?

Comment 2 Kevin Sawicki

2011-09-26 18:29:47 EDT

The first comment on that pull request is a commit comment, not a regular pull request comment.

The pull request editor does not currently show comments on commits or diffs.

Comment 3 Robert Munteanu

2011-09-27 02:45:44 EDT

(In reply to comment #2)
> The first comment on that pull request is a commit comment, not a regular pull
> request comment.
> 
> The pull request editor does not currently show comments on commits or diffs.

Thanks for the clarification. I've reworded this report as an enhancement ; I feel that this is important since the flow of comments was broken and I had no idea why.

Comment 4 Kevin Sawicki

2011-09-27 11:23:47 EDT

Yes, you are absolutely right, it does break the flow of comments when they are missing.