| Summary: | Goto line key binding should not use prompt | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Silenio Quarti <Silenio_Quarti> |
| Component: | Editor | Assignee: | Susan McCourt <susan> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | mamacdon |
| Version: | 0.2 | ||
| Target Milestone: | 0.4 M1 | ||
| Hardware: | PC | ||
| OS: | All | ||
| Whiteboard: | |||
| Bug Depends on: | 342739 | ||
| Bug Blocks: | |||
|
Description
Silenio Quarti
I'm working on this, but not done yet. In the lower level TextActions, we don't have knowledge of the outer page, so window prompt is going to have to be there. But up in editorCommands, we can use the command parameter stuff to get the parameter with a slideout, much like find and replace. As a first step I added "goto line" to the editor toolbar. When invoked from the command, the right thing happens (no prompt, just a little slide out). What I still need to do (next week) is to override the editor keybinding to do the command/parameter invocation rather than the underlying TextActions implementation. For this to work, there is some cleanup I need to do in the command framework to gather the right parameters (such as command dom ids) that are needed when the command executes from a keybinding. fixed. |