Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358941

Summary: AbstractStructuredGraphViewer.reveal(...) implemented incorrectly
Product: [Tools] GEF Reporter: Martin Burger <m>
Component: GEF-Legacy ZestAssignee: Zoltan Ujhelyi <zoltan.ujhelyi>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: m
Version: unspecified   
Target Milestone: ---   
Hardware: Macintosh   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
mylyn/context/zip none

Description Martin Burger CLA 2011-09-26 13:43:54 EDT 
According to the API specification (Javadoc comment) of method StructuredViewer.reveal(...), this method is supposed to ensure that the given element is visible, scrolling the viewer if necessary; the selection is unchanged.

However, class AbstractStructuredGraphViewer seems to violate the API contract, as it implements the specified behavior incorrectly. Method AbstractStructuredGraphViewer.reveal(...) highlights the given node and connection, respectively, but does not scroll the viewer if necessary. If the given node / connection to be revealed is not visible, nothing happens. Thus, that object is still not visible after calling AbstractStructuredGraphViewer.reveal(...).
Comment 1 Zoltan Ujhelyi CLA 2012-10-09 19:01:01 EDT 
Created attachment 222092 [details]
mylyn/context/zip

Attached Mylyn context
Comment 2 Zoltan Ujhelyi CLA 2012-10-09 19:02:01 EDT 
Fixed for Zest 2.0 in master.