Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358932

Summary:

Backport to 3.2.x [performance] DefaultFileServiceCodePageConverter is wasteful with main memory

Product:

[Tools] Target Management

Reporter:

David McKnight <dmcknigh>

Component:

RSE

Assignee:

David McKnight <dmcknigh>

Status:

RESOLVED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

CC:

jwsnyder, xuanchen

Version:

3.2.2

Flags:

xuanchen: review+

Target Milestone:

3.2.2+

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

280453

Bug Blocks:

Attachments:

Description	Flags
backport patch	none
update with fix for rename	none
update with fix for rename	none

Description David McKnight

2011-09-26 13:04:08 EDT

This bug is for the backport of the fix for bug 280453 to the R3_2_maintenance stream.

Comment 1 John W Snyder

2011-12-09 11:24:06 EST

Hi David... any idea when this backport will be completed?

Comment 2 David McKnight

2011-12-09 12:06:10 EST

Created attachment 208181 [details]
backport patch

Comment 3 David McKnight

2011-12-09 12:06:36 EST

Xuan, could you please review this backport?

Comment 4 David McKnight

2011-12-09 12:07:09 EST

(In reply to comment #1)
> Hi David... any idea when this backport will be completed?

John, I didn't know you guys needed this now.  I'll let you know when it's complete.

Comment 5 Xuan Chen

2011-12-09 16:44:24 EST

The fix looks good.  Thanks.

Comment 6 David McKnight

2011-12-09 16:51:35 EST

Thanks for the patch, Xuan.  I've committed the fix to the R3_2_maintenance stream.

Comment 7 David McKnight

2012-03-20 15:22:44 EDT

Reopening this because the call to:

altFile.renameTo(file);

is problemmatic.  java.io.File.renameTo() doesn't work when the file already
exists.

Comment 8 David McKnight

2012-03-20 15:29:57 EDT

Created attachment 212943 [details]
update with fix for rename

Comment 9 David McKnight

2012-03-20 15:31:18 EDT

Created attachment 212944 [details]
update with fix for rename

Comment 10 David McKnight

2012-03-20 15:34:35 EDT

I committed the update to the maintenance stream.