Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358920

Summary:	[DataBinding] WorkbenchProperties.SelectionServiceListener ignores arguments given to selectionChanged() when delegating to NativePropertyListener.fireChanged()
Product:	[Eclipse Project] Platform	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Dani Megert <daniel_megert>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	bokowski, daniel_megert, jawr, mallo.ovidio, ob1.eclipse, pwebster, qualidafial, remy.suen
Version:	3.7	Flags:	pwebster: review+
Target Milestone:	3.7.2
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	349297
Bug Blocks:

Description Dani Megert

2011-09-26 11:52:24 EDT

Backport request for bug bug 349297.

The inner class SelectionServiceListener always calls its inherited method fireChanged() with arguments (null, null) ignoring the part and selection passed to selectionChanged(). The super class NativePropertyListener creates a new SimplePropertyEvent in fireChanged() and passes through the null values. This results in an IllegalArgumentException ("null source") in the constructor of SimplePropertyEvent/EventObject. Due to this fact the provided WorkbenchProperties are unusable.

Comment 1 Dani Megert

2011-10-26 04:51:45 EDT

NOTE: This also needs to be cherry-picked into R4_maintenance.

Comment 2 Dani Megert

2011-11-08 03:26:40 EST

Paul, please approve for 3.7.2/4.1.2.

Comment 3 Paul Webster

2011-11-08 07:27:15 EST

I agree.

PW

Comment 4 Dani Megert

2011-11-08 08:31:15 EST

Fixed in R3_7_maintenance: 4cf77281d87a268a9e2963d94c740f33e8bb6b34

Comment 5 Dani Megert

2011-12-13 02:55:08 EST

Verified in M20111212-1000.