Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358888

Summary:

Backport to 3.0.x [performance] DefaultFileServiceCodePageConverter is wasteful with main memory

Product:

[Tools] Target Management

Reporter:

David McKnight <dmcknigh>

Component:

RSE

Assignee:

David McKnight <dmcknigh>

Status:

RESOLVED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

CC:

xuanchen

Version:

3.0.3

Flags:

xuanchen: review+

Target Milestone:

3.0.3+

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

280453

Bug Blocks:

Attachments:

Description	Flags
backport patch	none
update with fix for rename	none

Description David McKnight

2011-09-26 09:32:13 EDT

This bug is for the backport of the fix for bug 280453 to the R3_0_maintenance stream.

Comment 1 David McKnight

2011-09-26 09:35:03 EDT

Created attachment 204009 [details]
backport patch

Comment 2 David McKnight

2011-09-27 09:54:05 EDT

Kevin, could you please review this backport patch?

Comment 3 David McKnight

2011-10-06 09:45:11 EDT

Xuan, could you please review this backport?

Comment 4 Xuan Chen

2011-10-06 11:10:49 EDT

The fix looks good.  Thanks.

Comment 5 David McKnight

2011-10-06 11:20:53 EDT

Thanks for the review, Xuan.  I've committed the fix to the R3_0_maintenance stream.

Comment 6 David McKnight

2012-03-20 15:22:30 EDT

Reopening this because the call to:

altFile.renameTo(file);

is problemmatic.  java.io.File.renameTo() doesn't work when the file already
exists.

Comment 7 David McKnight

2012-03-20 15:35:03 EDT

Created attachment 212945 [details]
update with fix for rename

Comment 8 David McKnight

2012-03-20 15:52:30 EDT

I've committed the fix to the legacy stream.