Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358868

Summary:	Pull and Fetch Result dialogs are modal
Product:	[Technology] EGit	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Project Inbox <egit.ui-inbox>
Status:	VERIFIED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	markus.kell.r, matthias.sohn, remy.suen
Version:	1.1
Target Milestone:	1.3
Hardware:	All
OS:	All
Whiteboard:

Description Dani Megert

2011-09-26 07:08:39 EDT

1.1.0.201109151100-r.

The Fetch Result dialog is modal. This makes it hard to review incoming changes.

Only after a while I found out that I can open the 'Git Commit Editor' from that dialog and review the changes later.

Either the dialog should be non-modal or a view. As a first step a button that indicates that the commit can be opened in an editor would help.

Comment 1 Dani Megert

2011-10-03 07:12:20 EDT

See also bug 359688.

Comment 2 Markus Keller

2011-12-13 06:48:53 EST

I just pushed a change set to Gerrit to make the pull and fetch dialogs non-modal:
http://egit.eclipse.org/r/4802

Comment 3 Markus Keller

2012-01-10 09:54:56 EST

Ping.

This is also a pain when the fetch operation takes a while: After executing the command, I can work on, but as soon as the result dialog is shown, I'm blocked.

When I wrote the fix, I tried to find real-world scenarios where the longer life of non-modal dialogs could be a problem, but I didn't find any.

Comment 4 Stefan Lay

2012-01-11 03:44:11 EST

Fixed with 290973eacf4d931dfc97d7ff155768e044f8d3c1 

Maybe a view would even be better, that would avoid popping up a dialog after a background task.

Comment 5 Markus Keller

2012-01-13 12:30:51 EST

The original patch added the ON_TOP flag, which is not desirable (see comments in the original change set). Pushed remedy http://egit.eclipse.org/r/4954 .

Comment 6 Markus Keller

2012-01-17 12:25:23 EST

The ON_TOP flag is really a pain, sorry about that.
Could someone please release <http://egit.eclipse.org/r/4954>? Thanks.

Comment 7 Markus Keller

2012-01-20 06:59:39 EST

Ping. This is a trivial change (4 * remove SWT.ON_TOP) but the bug is major.

Comment 8 Matthias Sohn

2012-01-20 18:54:30 EST

merged as 9b8031a5d3d6d3c1dda01f75fbde396d8e954a33

Comment 9 Markus Keller

2012-01-22 16:43:53 EST

Thanks a lot, verified in org.eclipse.egit.ui_1.3.0.201201220815.