| Summary: | Double-click events may be fired when clicking while moving mouse | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [RT] RAP | Reporter: | Tim Buschtoens <tbuschto> | ||||
| Component: | RWT | Assignee: | Project Inbox <rap-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | jens.borrmann, ken.lee, tbuschto, wian | ||||
| Version: | 1.5 | ||||||
| Target Milestone: | 2.3 M2 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Tim Buschtoens
This is caused by unprecise doubleclick detection in EventUtil.js#_isDoubleClick. Selection events are fired by the widgets themselves, therefore it may be widget-specific whether or not this issue exists for those too. Relying only on qooxdoo doubleclick-events is currently not an option, as the browser may not fire doubleklick events when the dom changes between the clicks. A clean solution for this issue could be to refactor EventHandler.js and EventHandlerUtil.js to handle all doubleclick detection in the same manner as the key-events. Created attachment 216553 [details]
Patch Proposal for function_isDoubleClick
A simple patch to this bug disregarding acceptable small deviation of the mouseclicks is to check in the function _isDoubleClick in EventUtil.js if the current event coordinates correspond to the last mousedown event coordinates. Only if they both match, the mouse click will be considered as a double click.
This behavior is more accurate than the current one.
Is there any chance that this bug will be fixed for RAP 2.1.1? Is this bug going to be fixed in RAP 2.3? There is currently no concrete plan to do so. It's not a big task, but we have a lot of those. If it has a high priority I suggest you contact us directly. Fixed in master with change https://git.eclipse.org/r/22614 |