Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358750

Summary: Need a more direct way to edit repository properties
Product: [Technology] EGit Reporter: Carolyn MacLeod <carolynmacleod4>
Component: UIAssignee: Project Inbox <egit.ui-inbox>
Status: CLOSED WORKSFORME QA Contact:
Severity: normal    
Priority: P3 CC: remy.suen
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Carolyn MacLeod CLA 2011-09-23 13:02:50 EDT
EGit 1.2.0.201109231014

- I have several repositories
- I just finished cloning them, and I am still in the Git Repositories view
- Now I want to set branch.master.rebase=true on the repositories
- To do this, I have to go to Window -> Preferences -> Team -> Git -> Configuration -> Repository Settings

This feels like a very roundabout way to edit a property on a repository I have just cloned.

It would be nicer if I could just right click on a repository and select "Preferences..." from the context menu, which would go directly to the Repository Settings tab in the Preferences dialog.

For an example of where this type of thing is done in Eclipse, right-click in any Java editor and select "Preferences..." from the context menu, and you will be taken directly to the Java Editor Preferences page.
Comment 1 Remy Suen CLA 2011-09-23 13:59:09 EDT
You should be able to use the 'Git Repositories' view with the 'Properties' view for editing the properties. This might streamline it a little for you, Carolyn.
Comment 2 Carolyn MacLeod CLA 2011-09-23 14:52:32 EDT
How bizarre! The Edit... tool in the Properties view was not there a few minutes ago, and now it is. I am not sure what I did to get it to appear - maybe I resized the window or something? I actually did look for a way to add a property in the properties view, and I very much got the impression that it was a read-only thing because there were no edit tools. But now it suddenly has more tools... (the "Repository Configuration" and "Single Value" tools have magically appeared as well).  (Poltergeist <g>).

Yes, that's much better. Except that the tools don't always show up, for some reason. The tools aren't there on my Mac, either. Aha - resizing the window does make them show up! I think this is an e4 action contribution bug somehow, and I will dig into it a bit more.
Comment 3 Remy Suen CLA 2011-09-23 14:54:58 EDT
(In reply to comment #2)
> How bizarre! The Edit... tool in the Properties view was not there a few
> minutes ago, and now it is.

Actually, I experienced the same problem while I was reproducing the steps locally before commenting on this bug. :O

> I think this is an e4 action contribution bug somehow,
> and I will dig into it a bit more.

Carolyn, do you want to close this EGit bug or just move it to Platform UI for now?
Comment 4 Carolyn MacLeod CLA 2011-09-23 15:09:08 EDT
I'll close it now. The current intended behavior is fine.

I showed the UI problem to Eric, and he believes there's already a UI bug open for something similar. I'll comment on that one.
Comment 5 Eric Moffatt CLA 2011-09-26 09:43:08 EDT
Carolyn, I was thinking of bug 344832. I'll see if I can address that one today and we can check if it will help this one (I'm less convinced after watching you play with the scenarios though but it may help).