Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358727

Summary: Improve performance of StateBasedContainer.filterByURI
Product: [Modeling] TMF Reporter: Lieven Lemiengre <lieven.lemiengre>
Component: XtextAssignee: Project Inbox <tmf.xtext-inbox>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: mark.g.j.christiaens, sebastian.zarnekow, sven.efftinge
Version: 2.1.0Flags: sebastian.zarnekow: indigo+
Target Milestone: SR2   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch sven.efftinge: iplog+

Description Lieven Lemiengre CLA 2011-09-23 10:15:58 EDT
Created attachment 203907 [details]
patch

This patch improves the build performance when multiple projects depend on eachother.

In StateBasedContainer, the methodcall IContainerState.getContents() is expensive so I've cached the result.

In ResourceDescriptionsBasedContainer the filter can be eliminated because hasResourceDescription(URI) is always true.
Comment 1 Sebastian Zarnekow CLA 2011-09-27 05:35:13 EDT
Scheduled for review
Comment 2 Sebastian Zarnekow CLA 2011-10-09 12:25:47 EDT
Patch looks good. Pushed to master.

Thanks, Lieven.
Comment 3 Karsten Thoms CLA 2017-09-19 17:22:33 EDT
Closing all bugs that were set to RESOLVED before Neon.0
Comment 4 Karsten Thoms CLA 2017-09-19 17:33:58 EDT
Closing all bugs that were set to RESOLVED before Neon.0