Bug 358708

Comment 1 Ed Willink 2012-04-11 15:52:04 EDT

Needs re-classing so that all UML-specific stuff is in sacrificial classes.

Comment 2 Ed Willink 2014-01-23 11:35:57 EST

Not optional at all as discovered when removing the re-exports for UML2 5.0.

UMLResourcesUtil is accessed by PivotStandaloneSetup. A variety of UML constants are also accessed.

TemplateSignature has a subset parameter/owmedParameter that requires UML support; this has been eliminated.

Most of the problems are easily resolved. edw/358708 is nearly done. But

OCL.uml2pivot need moving to 'UML'
PivotStandaloneSetup.init access of UMLASREsourceFactory needs ???
Editor satrtups for UML need ???

need a little more thought than there is currently time for.

Until then clients must provide their own UML depedencies.

Comment 3 Rolf Theunissen 2014-08-01 05:03:21 EDT

Changing the init method of PivotStandaloneSetup, to not only catch an exception if UMLResourceUtil is accessed but also if UMLASResourceFactory is accessed, seems to remove the dependency on UML.

For instance:

try {
  UMLASResourceFactory.INSTANCE.getClass();
  UMLResourcesUtil.init(null);
} catch (Throwable e) {} // UML is optional so may get a ClassNotFoundException

Comment 4 Ed Willink 2015-01-01 10:35:08 EST

The promotion to non-'examples' for Mars isolates UML support in org.eclipse.ocl.pivot.uml that naively solves the problems, but creates new ones.

Simplistically a UMLEnvironmentFactory rather than a PivotEnvironmentFactory must be created whenever UML support is required. If the user has already populated a ResourceSet we can be 'telepathic' by analyzing the ResourceSet for UMLResources. However if all we know is that we have a Complete OCL document, we don't know about UML until after we analyze the import statements.

For standalone applications it's a user problem; user must invoke UMLOCL.newInstance() rather than OCL.newInstance(). For plugin usage such as OCL editors we must assume the worst. If the pivot.uml plugin is installed, the ASResourceFactory extension point provides a UMLASResourceFactory and so that is what we must use to create the default EnvironmentFactory.

Comment 5 Ed Willink 2015-02-09 03:39:36 EST

(In reply to Ed Willink from comment #4)
> Simplistically a UMLEnvironmentFactory rather than a PivotEnvironmentFactory

The correct EnvironmentFactory is now chosen according to the ASResourceFactory registrations.

> For standalone applications it's a user problem; user must invoke
> UMLOCL.newInstance() rather than OCL.newInstance(). For plugin usage such as

UMLOCL is redundant.

User just needs to invoke UMLStandaloneSwetup.init() to install the UMLASResourceFactory  registration.

Pushed to master for M5.