Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358666

Summary: Diagram implicit connections don't synchronize with external editor changes
Product: z_Archived Reporter: Shenxue Zhou <shenxue.zhou>
Component: SapphireAssignee: Shenxue Zhou <shenxue.zhou>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: raj.alagumalai
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Shenxue Zhou CLA 2011-09-22 17:03:15 EDT
If a diagram model contains implicit connections, when the model is changed in an external editor, and if the changes impact implicit connections such as new nodes need to be added to the implicit connections or nodes need to be deleted from implicit connections, the diagram's rendering of implicit connections doesn't synchronize with external editor changes.

The reason for is both the implicit connection template and the corresponding node template listen for model property changes. But there is no particular order on which gets notified first. So when the implicit connection template is notified about a new model element, it could very well be that the corresponding node template hasn't been notified and therefore a new node part hasn't been created.

The solution is to register a node template listener inside the implicit connection template. When a new node part is added by the node template, the implicit connection template will be notified and it can refresh the implicit connections.
Comment 1 Shenxue Zhou CLA 2011-09-22 17:47:09 EDT
Fixed by introducing node template listener in diagram implicit connection template
Comment 2 Raj Alagumalai CLA 2011-09-23 15:38:53 EDT
verified with 0.3.1.201109221708
Comment 3 Shenxue Zhou CLA 2011-09-23 15:52:35 EDT
Closing based on Raj's verification