Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358659

Summary:	REST binding browse button returns the wrong value
Product:	z_Archived	Reporter:	Joseph Vincens <jvincens>
Component:	EDT	Assignee:	Tony Chen <chenzhh>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	cdlwuxin, chenzhh, jspadea
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description Joseph Vincens

2011-09-22 16:16:01 EDT

In the egldd editor Resource Binding tab.
After pressing add REST there is a browse button that returns an interface or service type. In EDT the resource binding name is no longer a Part name it's a variable name see 358310 and 358309.
It would be best to just remove the button and let the user enter a name. The name will need to be a valid EGL identifier.

Comment 1 Justin Spadea

2011-09-23 09:17:45 EDT

Joe - can the user specify anything they want (spaces, slashes, etc) for the bindingKey property of @Resource? If so then we should not prevent such characters from being manually entered. I think that we should only remove invalid identifier characters when we default the binding name (like with the SQL binding wizard).

Comment 2 Joseph Vincens

2011-09-23 09:25:09 EDT

Justin is correct, if the user wants to use @Resource{bindingKey="mm nn%@/"} that is legal so we should not add any validation to this page, we should simply remove the button.

Comment 3 Justin Spadea

2011-10-03 16:47:46 EDT

The browse button has been removed, and we also now validate that the binding name is not blank. Modified:

NewWizardMessages.java
NewWizardMessages.properties
RestBindingWizardPage.java

Comment 4 Joseph Vincens

2011-10-24 16:35:59 EDT

verified

Comment 5 Joseph Vincens

2011-10-24 16:36:46 EDT

verified