Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358650

Summary: Automatic History view updating should not block UI thread
Product: [Technology] EGit Reporter: Markus Keller <markus.kell.r>
Component: UIAssignee: Project Inbox <egit.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: amj87.iitr, daniel_megert, jamesblackburn+eclipse, matthias.sohn, Olivier_Thomann, remy.suen, stephan.herrmann
Version: 1.1   
Target Milestone: 2.0-M1   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Markus Keller CLA 2011-09-22 15:20:18 EDT
1.1.0.201109151100-r

The EGit History view implementation is blocking the UI thread too often. When the view is open and "Link with Editor and Selection" is enabled, I cannot work normally any more, e.g. switching editors as I like.

The refresh of the view must be implemented in a way that doesn't interfere with normal user actions. When I e.g. open 4 editors from a Git project and then use Ctrl+PageUp/Down to switch between them, I often have to wait for several seconds, especially if I want to jump by 2 or more tabs.

The Eclipse CVS implementation does not exhibit such delays.
Comment 1 Ayushman Jain CLA 2011-09-29 13:05:52 EDT
I have observed many more problems when the "Link with editor.." is enabled. Saving a java file hangs the UI, so does adding/removing/skip all breakpoints. I switched off "link with edtor" and things returned to normal. (I have had these issues even without the History view open though).
Comment 2 James Blackburn CLA 2011-09-29 15:39:28 EDT
(In reply to comment #1)

See also: bug 323839 & bug 358898.  Egit has some very heavy-weight resource change handlers that lock-up the IDE easily.
Comment 3 Matthias Sohn CLA 2012-03-13 19:57:38 EDT
merged as 325bde8c198119a5601bf9d9e873f59ae0b4e3c0