Bugzilla – Full Text Bug Listing
| Summary: | Line insertion is long lines is slow | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Kevin Dangoor <kid> |
| Component: | Editor | Assignee: | Project Inbox <orion.editor-inbox> |
| Status: | RESOLVED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | eclipse.felipe, mihai.sucan, Silenio_Quarti, simon_kaegi |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Kevin Dangoor
We added some performance tests to measure text insertion and cursor navigation of very longs. These tests can be run from: orion.eclipse.org/examples/textview/demo.html We optimized the creation of very longs lines by reusing the line spans when possible. Before we were creating the whole line DOM when the text or style of any span in the line changed. The improvement varies depending on the browser and test, but it is at least 25% faster. Please try the latest and let us know whether the improvement is noticeable for you. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=7d233a995957a01c005b5b9bfb2d1447b4af6d59 http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=dfc36f7bb02f10278045ecef401761daf7e4dc73 (In reply to comment #1) > We added some performance tests to measure text insertion and cursor navigation > of very longs. These tests can be run from: > > orion.eclipse.org/examples/textview/demo.html > > We optimized the creation of very longs lines by reusing the line spans when > possible. Before we were creating the whole line DOM when the text or style of > any span in the line changed. > > The improvement varies depending on the browser and test, but it is at least > 25% faster. > > Please try the latest and let us know whether the improvement is noticeable for > you. > > http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=7d233a995957a01c005b5b9bfb2d1447b4af6d59 > > http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=dfc36f7bb02f10278045ecef401761daf7e4dc73 Thanks a lot for your work. This is awesome stuff and it's quite faster for me (on my system). There's one regression. STR: 1. Load the Orion simple demo, load some code (say JS). 2. Go to any line that is shorter than the line above it and press End. 3. Press Up. Expected result: the cursor moves to the line up maintaining column X. Actual result: the cursor moves to the line up + 1 char to the right. Cause: a typo. Landed a fix: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=dec27f40eb5fac83677cdae9b3c8e413a9b58d1c (In reply to comment #2) > Thanks a lot for your work. This is awesome stuff and it's quite faster for me > (on my system). Awesome! > 1. Load the Orion simple demo, load some code (say JS). > 2. Go to any line that is shorter than the line above it and press End. > 3. Press Up. > > Expected result: the cursor moves to the line up maintaining column X. > > Actual result: the cursor moves to the line up + 1 char to the right. > > Cause: a typo. Landed a fix: > > http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=dec27f40eb5fac83677cdae9b3c8e413a9b58d1c Good catch! Please, feel free to push this change. (In reply to comment #3) > > http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=dec27f40eb5fac83677cdae9b3c8e413a9b58d1c > > Good catch! Please, feel free to push this change. Thanks! I already did. That's the push link. ;) Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html |