Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358614

Summary:	Superfluous comma in Typo in Compare With > Branch, Tag, or Reference...
Product:	[Technology] EGit	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Project Inbox <egit.ui-inbox>
Status:	VERIFIED FIXED	QA Contact:
Severity:	trivial
Priority:	P3	CC:	markus.kell.r, matthias.sohn, remy.suen
Version:	1.1
Target Milestone:	1.2
Hardware:	All
OS:	All
Whiteboard:

Description Dani Megert

2011-09-22 11:53:28 EDT

1.1.0.201109151100-r.

Superfluous comma in Typo in Compare With > Branch, Tag, or Reference...

Branch, Tag, or Reference... ==> Branch, Tag or Reference...

Comment 1 Matthias Sohn

2011-09-30 17:12:30 EDT

pushed patch for review  
http://egit.eclipse.org/r/4316

Comment 2 Markus Keller

2011-10-04 07:48:31 EDT

-1. The serial comma is perfectly OK in English, see e.g. http://en.wikipedia.org/wiki/Serial_comma

The "Windows User Experience Interaction Guidelines" also say it should be there:
http://msdn.microsoft.com/en-us/library/aa974176.aspx#punctuation

Comment 3 Matthias Sohn

2011-10-08 19:26:16 EDT

merged as 5252b87d11f3079fb1cc9be4752cb0fd19083434

there seems to be no strict rule on usage of serial comma
at least some of us seem to prefer not to use it.

Comment 4 Dani Megert

2011-10-27 12:05:01 EDT

(In reply to comment #3)
> merged as 5252b87d11f3079fb1cc9be4752cb0fd19083434
> 
> there seems to be no strict rule on usage of serial comma
> at least some of us seem to prefer not to use it.

Matthias, either you should revert as suggested by Markus or adjust all UI strings. Currently we have a mix. E.g, after executing the action I get a dialog with different typing.

Comment 5 Matthias Sohn

2011-11-30 16:24:33 EST

Pushed revert of my change for review: http://egit.eclipse.org/r/4703

Comment 6 Matthias Sohn

2011-12-01 17:27:23 EST

merged as 075474939440de065705e739ecac66309230f9f6

Comment 7 Dani Megert

2011-12-06 06:22:45 EST

Verified in 1.2.0.201112051848.