Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358583

Summary: Unable to add Review items - Compare Editor - Planning and Preparation
Product: z_Archived Reporter: Alvaro Sanchez-Leon <alvaro.sanchez-leon>
Component: MylynAssignee: Sebastien Dubois <sebastien.dubois>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: lmcbout, sebastien.dubois
Version: unspecified   
Target Milestone: 0.9   
Hardware: All   
OS: All   
Whiteboard:

Description Alvaro Sanchez-Leon CLA 2011-09-22 09:21:32 EDT 
Context: Formal Reviews, Planning and Preparation phase, Compare Editor

The context menu from the Compare Editor has the option to add Review Items disabled / grayed out when in Preparation and Plnanning phase
Comment 1 Sebastien Dubois CLA 2011-09-28 00:48:10 EDT 
Preventing creating review items from commit review items was done on purpose, to avoid confusion.  After team discussion, we decided to remove it.  This is done here so now Review Items can be added from other review items.  However the newly created review items will be attached to their own Resource Review Items to avoid confusing them with Commit Review Items created using the "Find Review Items" command.

I also cleanup up the code a bit when opening text editors.
Comment 2 Alvaro Sanchez-Leon CLA 2011-09-28 14:33:36 EDT 
The behaviour above seems to work fine for Formal Reviews however it does not create a separate Resource Review item when using basic reviews.
   
Needs to be verified for the three review types.
Comment 3 Sebastien Dubois CLA 2011-09-28 22:52:51 EDT 
Should be fixed with the fix for bug 359246.  We will verify this
Comment 4 Sebastien Dubois CLA 2011-09-29 17:39:17 EDT 
  I refined the way we check the compare editor input to set the proper base and target version for all the possible cases of Adding a Review Item I could think of (file not in source control, file in source control, but modified in workspace, file in source control), that are opened either with the single editor or compare editor, for files in any version control system (or workspace), and when adding a review items from any input (Package, Project Explorer, Navigator, and R4E itself).
  
  So all cases should be covered and the proper target and base versions should be present now