Bugzilla – Full Text Bug Listing
| Summary: | [user] Should be able to close the authentication hint box | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Szymon Brandys <Szymon.Brandys> | ||||||||||||
| Component: | Client | Assignee: | Malgorzata Janczarska <malgorzata.tomczyk> | ||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||
| Severity: | normal | ||||||||||||||
| Priority: | P3 | CC: | susan | ||||||||||||
| Version: | unspecified | Flags: | Szymon.Brandys:
review+
|
||||||||||||
| Target Milestone: | 0.4 RC2 | ||||||||||||||
| Hardware: | PC | ||||||||||||||
| OS: | Windows 7 | ||||||||||||||
| Whiteboard: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Szymon Brandys
Right now after some recent changes you need to click on the tooltip and then click somewhere else to close it, but I don't think this is something the we want to have as a target solution of this problem, because this is not obvious for the user. I've been thinking what would be the ideal solution here and it I think we should do it this way: 1. Add "No, thanks" button after "Sign In" 2. Clicking "No, thanks" button on only closes the popup, but also doesn't show it again on this page Even better would be to notify error listeners of deferreds invoking the services after "No, thanks" is clicked. Now they always wait user to log in and retry. But this requires more changes that is safer to push to 0.5. I would like to see "close" icon similar to that in the notification area. It should be enough for .4. Other improvements would be welcome but in .5. Created attachment 210981 [details]
First proposition
This patch adds a link closing the window. I'm working on a second version, to close the dialog with an "x". This is Szymon's suggestion, we'll see how this will look like.
Created attachment 210987 [details]
Popup ex on the right
Created attachment 210988 [details]
Popup ex on top
Created attachment 210989 [details]
popup with link
Susan, we've been thinking with Szymon how can we add a link closing the login dialog. Above there are 3 propositions in screenshoots: two of the with an "x" icon and one with a link. We don't want to hide the popup just by clicking anywhere on the application because sometimes this is the only way to log in (when there is no authentication plugin) and there is no way to revoke this dialog. That's why we want an explicit way of closing this dialog. I like the "X" on the right. It's a bit funny in that it's right under the tooltip pointer thingy but I still think it looks the best and is in the most expected place. (In reply to comment #8) > I like the "X" on the right. > It's a bit funny in that it's right under the tooltip pointer thingy but I > still think it looks the best and is in the most expected place. Thanks Susan, It's a "paint screenshot", so in the real solution I'll try to put it under the pointer. Created attachment 211027 [details]
Closing with
attachment 211027 [details] contains patch closing with "x" on the right.
Looks good. You could update the copyright header with the right date too. (In reply to comment #12) > Looks good. You could update the copyright header with the right date too. done |