Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358534

Summary:

GitProjectSetCapability swallows exceptions (InvocationTargetException)

Product:

[Technology] EGit

Reporter:

GianMaria Romanato <gm.romanato>

Component:

Core

Assignee:

Project Inbox <egit.core-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

jens.baumgart, matthias.sohn

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

All

Whiteboard:

Attachments:

Description	Flags
A proposed patch	none

Description GianMaria Romanato

2011-09-22 04:56:33 EDT

Build Identifier: 1.1.0.201109151100-r

The current implementation of addToWorkspace method catches InvocationTargetException and throws a team exception without unboxing the original exception, therefore loosing details about the original problem

Reproducible: Always

Steps to Reproduce:
1. perform a clone that makes CloneOperation.run throw an InvocationTargetException
2. the raised TeamException looses detail about the original exception

Comment 1 GianMaria Romanato

2011-09-22 04:56:58 EDT

Created attachment 203824 [details]
A proposed patch

Comment 2 Matthias Sohn

2011-09-29 07:39:40 EDT

Could you push this patch to our code review server as described in the EGit Contributor Guide [1] ?

[1] http://wiki.eclipse.org/EGit/Contributor_Guide

Comment 3 GianMaria Romanato

2011-09-29 11:45:55 EDT

My colleague Renato registered to gerrit and pushed a cumulative patch for this defect and for defect #358530.

As this is the first time we used gerrit, please double check we did not make any mistake.
Thanks.

Comment 4 Jens Baumgart

2011-09-30 12:00:54 EDT

Fixed with commit 9953f30844f843a7dc57ac42468ea2106e12f873