| Summary: | [Commands] MenuManagerRendererFilter#updateElementVisibility() uses 45% of the time when opening & closing views | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Oleg Besedin <ob1.eclipse> |
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> |
| Status: | RESOLVED FIXED | QA Contact: | Paul Webster <pwebster> |
| Severity: | normal | ||
| Priority: | P3 | CC: | remy.suen |
| Version: | 4.2 | ||
| Target Milestone: | 4.2 M6 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 358490 | ||
Aggregate move to M5. Retarget to a different milestone if you wish... I know we made some improvements to the updateElementVisibility code. Are we being caught out again by getActiveLeaf() calls? PW Using current code base, MenuManagerRendererFilter#updateElementVisibility() takes about 8% of the time in the open view / close view cycle. (In reply to comment #3) > Using current code base, MenuManagerRendererFilter#updateElementVisibility() > takes about 8% of the time in the open view / close view cycle. |
The MenuManagerRendererFilter#updateElementVisibility() method takes up 45% of the time of the cycle { opening view, close view }. The method is called ~220 times per cycle { open view, close view }.