Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358494

Summary: [Commands] MenuManagerRendererFilter#updateElementVisibility() uses 45% of the time when opening & closing views
Product: [Eclipse Project] Platform Reporter: Oleg Besedin <ob1.eclipse>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: RESOLVED FIXED QA Contact: Paul Webster <pwebster>
Severity: normal    
Priority: P3 CC: remy.suen
Version: 4.2   
Target Milestone: 4.2 M6   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 358490    

Description Oleg Besedin CLA 2011-09-21 17:00:27 EDT
The MenuManagerRendererFilter#updateElementVisibility() method takes up 45% of the time of the cycle { opening view, close view }.

The method is called ~220 times per cycle { open view, close view }.
Comment 1 Eric Moffatt CLA 2011-12-09 13:09:46 EST
Aggregate move to M5. Retarget to a different milestone if you wish...
Comment 2 Paul Webster CLA 2012-02-14 11:55:16 EST
I know we made some improvements to the updateElementVisibility code.  Are we being caught out again by getActiveLeaf() calls?

PW
Comment 3 Oleg Besedin CLA 2012-02-15 11:56:53 EST
Using current code base, MenuManagerRendererFilter#updateElementVisibility() takes about 8% of the time in the open view / close view cycle.
Comment 4 Oleg Besedin CLA 2012-03-28 14:42:48 EDT
(In reply to comment #3)
> Using current code base, MenuManagerRendererFilter#updateElementVisibility()
> takes about 8% of the time in the open view / close view cycle.