Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 358388

Summary: Refinements to "Existing Code as Makefile Project"
Product: [Tools] CDT Reporter: Salvatore Culcasi <salvatore.culcasi>
Component: cdt-buildAssignee: cdt-build-inbox <cdt-build-inbox>
Status: RESOLVED FIXED QA Contact: Chris Recoskie <recoskie>
Severity: enhancement    
Priority: P3 CC: cdtdoug, john.cortell
Version: 8.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 326105    
Attachments:
Description Flags
patch for wizard page
none
PAtch generated with egit
none
Patch generated from HEAD with egit
none
final patch cdtdoug: iplog+

Description Salvatore Culcasi CLA 2011-09-21 06:04:20 EDT 
Build Identifier: I20110613-1736

The "Import Code" wizard page should be improved
- List of toolchain widget with border
- List of toolchain widget grabs vertical and horizontal spaces
- Add "show supported toolchains" checkbox to filter toolchains


Reproducible: Always
Comment 1 Salvatore Culcasi CLA 2011-09-21 06:05:48 EDT 
Created attachment 203746 [details]
patch for wizard page

Added patch to amend the UI behaviour
Comment 2 Andrew Gvozdev CLA 2011-09-21 13:59:45 EDT 
(In reply to comment #1)
> Created attachment 203746 [details]
> patch for wizard page
The patch doesn't apply on latest CDT repository. Please make sure you build patch against CDT master. Note that if you make it with egit - it makes patch only against previous commit.
Comment 3 Salvatore Culcasi CLA 2011-09-23 04:39:26 EDT 
Created attachment 203885 [details]
PAtch generated with egit

This patch has been generated using egit, form history view (master)
(Previous patch to be applied needs to be skipped  3 leading segments)
Please let me know if it is OK
Comment 4 Andrew Gvozdev CLA 2011-09-23 09:46:11 EDT 
I cannot apply neither one. The second one got lots of unrelated stuff, won't apply. For the first one there is no problem with leading segments but there are unmatched hunks.
Comment 5 Salvatore Culcasi CLA 2011-09-28 05:36:25 EDT 
Created attachment 204157 [details]
Patch generated from HEAD with egit

Previous patch obsoleted, they were created using a wrong source base
Comment 6 Salvatore Culcasi CLA 2011-09-28 10:56:47 EDT 
Created attachment 204195 [details]
final patch

previous patch had a mistyping in message.properties file
Comment 7 Andrew Gvozdev CLA 2011-09-28 15:41:58 EDT 
(In reply to comment #6)
> Created attachment 204195 [details]
> final patch
> previous patch had a mistyping in message.properties file
I don't know how you create your patches but it isn't working. For a recent example of a patch in a good format see bug 359176.
Why don't you clone original CDT repository and try to apply your patch in eclipse before submission?
Comment 8 Salvatore Culcasi CLA 2011-09-29 03:16:58 EDT 
(In reply to comment #7)
> (In reply to comment #6)
> > Created attachment 204195 [details]
> > final patch
> > previous patch had a mistyping in message.properties file
> I don't know how you create your patches but it isn't working. For a recent
> example of a patch in a good format see bug 359176.
> Why don't you clone original CDT repository and try to apply your patch in
> eclipse before submission?

I created the patch using GIT-history view
Previous patches were "wrong" because I used the base, now for patch I started from SD90
To be honest I applied the patch before submitting here, but it was working for me.
Please could tell what went wrong when you tried to apply it?
Comment 9 Andrew Gvozdev CLA 2011-09-29 10:58:04 EDT 
(In reply to comment #8)
> I created the patch using GIT-history view
> Previous patches were "wrong" because I used the base, now for patch I started
> from SD90
You shouldn't use sd90 branch, that is side development for bug 290631. Use "master" branch.

> To be honest I applied the patch before submitting here, but it was working for
> me.
> Please could tell what went wrong when you tried to apply it?
The problem with the latest patch is with leading segments. Neither choice in "Apply Patch" dialog finds the files. I am using "Apply the patch to the workspace root" option. We use that as patches often span across the projects.
Comment 10 John Cortell CLA 2012-02-16 16:42:23 EST 
Resolved with 326105. I used some of the code from the patch. Thanks.